Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix misunderstanding in generated README #726

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Fix misunderstanding in generated README #726

merged 1 commit into from
Apr 17, 2024

Conversation

palas
Copy link
Contributor

@palas palas commented Apr 16, 2024 •
edited by carbolymer
Loading

Changelog

- description: |
    Fixed misunderstanding in generated README file by `genesis create-testnet-data`.
  type:
   - bugfix

Context

This just fixes a wrong explanation that I wrote due to a misunderstanding that caused me to conflate the two types of DReps (Catalyst's and CIP-1694's).

I found out because I read a note in the CIP-1694 that precisely says:

Warning CIP-1694 DReps should not be conflated with Project Catalyst DReps.

How to trust this PR

If you don't know by heart whether this was actually a mistake. You can check the source here: https://www.1694.io/, under the Delegated representatives (DReps) section. You should also check I didn't make any typo.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

carbolymer
carbolymer reviewed Apr 17, 2024
View reviewed changes
cardano-cli/src/Cardano/CLI/EraBased/Run/CreateTestnetData.hs
["Keys generated by the --drep-keys flag. These keys are for Delegate Representatives (DReps) that make decisions in",
"Funds of the Catalyst Project. Delegators that do not want to vote for each decision will pick DReps in line with",
["Keys generated by the --drep-keys flag. These keys are for Delegate Representatives (DReps) that make decisions",
"related to Cardano governance. Delegators that do not want to vote for each decision will pick DReps in line with",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Can you check with @CarlosLopezDeLara too?

CarlosLopezDeLara
CarlosLopezDeLara approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@CarlosLopezDeLara CarlosLopezDeLara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better!

@palas palas added this pull request to the merge queue Apr 17, 2024
Merged via the queue into main with commit f8d0989 Apr 17, 2024
16 checks passed
@palas palas deleted the fix-doc-error branch April 17, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carbolymer carbolymer carbolymer left review comments

@smelc smelc smelc approved these changes

@CarlosLopezDeLara CarlosLopezDeLara CarlosLopezDeLara approved these changes

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350 Jimbo4350 is a code owner

@newhoggy newhoggy Awaiting requested review from newhoggy newhoggy is a code owner

@kevinhammond kevinhammond Awaiting requested review from kevinhammond kevinhammond is a code owner

@disassembler disassembler Awaiting requested review from disassembler disassembler is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@palas @carbolymer @smelc @CarlosLopezDeLara