Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add minFeeRefScriptCostPerByte to create-protocol-param-update + bump cardano-api #736

Merged
merged 1 commit into from
Apr 25, 2024
Merged

add minFeeRefScriptCostPerByte to create-protocol-param-update + bump cardano-api #736

merged 1 commit into from
Apr 25, 2024

Conversation

CarlosLopezDeLara
Copy link
Contributor

@CarlosLopezDeLara CarlosLopezDeLara commented Apr 23, 2024 •
edited
Loading

Changelog

- description: |
    Add `minFeeRefScriptCostPerByte`  to create-protocol-parameter-update governance action command. 
# uncomment types applicable to the change:
  type:
   - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Resolves #598

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@CarlosLopezDeLara
Copy link
Contributor Author

Depends on IntersectMBO/cardano-api#524

@CarlosLopezDeLara CarlosLopezDeLara marked this pull request as ready for review April 23, 2024 23:02
@CarlosLopezDeLara CarlosLopezDeLara marked this pull request as draft April 24, 2024 05:58
@CarlosLopezDeLara CarlosLopezDeLara marked this pull request as ready for review April 25, 2024 01:54
@CarlosLopezDeLara CarlosLopezDeLara requested review from a team as code owners April 25, 2024 02:28
smelc
smelc reviewed Apr 25, 2024
View reviewed changes
cabal.project Show resolved Hide resolved
@smelc smelc changed the title add minFeeRefScriptCostPerByte to create-protocol-param-update add minFeeRefScriptCostPerByte to create-protocol-param-update + bump cardano-api Apr 25, 2024
carbolymer
carbolymer approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. One minor comment about deduplication.

Jimbo4350
Jimbo4350 requested changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 . One comment and these commits need to be squashed.

cardano-cli/src/Cardano/CLI/EraBased/Options/Common.hs Outdated Show resolved Hide resolved
@CarlosLopezDeLara CarlosLopezDeLara marked this pull request as draft April 25, 2024 13:19
@CarlosLopezDeLara CarlosLopezDeLara marked this pull request as ready for review April 25, 2024 13:51
@CarlosLopezDeLara
Copy link
Contributor Author

@Jimbo4350 I think all comments have been addressed.

Jimbo4350
Jimbo4350 approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CarlosLopezDeLara
add minFeeRefScriptCostPerByte to create-protocol-param-update + bump…
2360183 
… cardano-api

Signed-off-by: Carlos LopezDeLara <carlos.lopezdelara@iohk.io>
@CarlosLopezDeLara CarlosLopezDeLara added this pull request to the merge queue Apr 25, 2024
Merged via the queue into main with commit 175620e Apr 25, 2024
21 checks passed
@CarlosLopezDeLara CarlosLopezDeLara deleted the cl/minRefScriptCostPerByte branch April 25, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@newhoggy newhoggy Awaiting requested review from newhoggy newhoggy is a code owner

@palas palas Awaiting requested review from palas palas is a code owner

@kevinhammond kevinhammond Awaiting requested review from kevinhammond kevinhammond is a code owner

@disassembler disassembler Awaiting requested review from disassembler disassembler is a code owner

@carbolymer carbolymer Awaiting requested review from carbolymer carbolymer is a code owner

@smelc smelc Awaiting requested review from smelc smelc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] - Incorporate the new parameter minFeeRefScriptsCoinsPerByte
4 participants
@CarlosLopezDeLara @carbolymer @smelc @Jimbo4350