Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing implementation for STS class methods #2354

Closed
lehins opened this issue Jun 24, 2021 · 1 comment · Fixed by #2356
Closed

Missing implementation for STS class methods #2354

lehins opened this issue Jun 24, 2021 · 1 comment · Fixed by #2356

Comments

@lehins
Copy link
Contributor

lehins commented Jun 24, 2021

Recent commit 0128d81 introduced Event type family and wrapEvent class method. Implementation is missing AlonzoUTXO era and results in a compile time warning:

src/Cardano/Ledger/Alonzo/Rules/Utxo.hs:466:1: warning: [-Wmissing-methods]
     No explicit associated type or default declaration for Event
     In the instance declaration for STS (AlonzoUTXO era)
    |
466 | instance
    | ^^^^^^^^...

src/Cardano/Ledger/Alonzo/Rules/Utxo.hs:511:3: warning: [-Wmissing-methods]
     No explicit implementation for
        wrapEvent
     In the instance declaration for
        Embed (UTXOS era) (AlonzoUTXO era)
    |
511 |   ( Era era,
    |   ^^^^^^^^^^...

src/Cardano/Ledger/Alonzo/Rules/Utxow.hs:418:1: warning: [-Wmissing-methods]
     No explicit associated type or default declaration for Event
     In the instance declaration for STS (AlonzoUTXOW era)
    |
418 | instance
    | ^^^^^^^^...

src/Cardano/Ledger/Alonzo/Rules/Utxow.hs:450:3: warning: [-Wmissing-methods]
     No explicit implementation for
        wrapEvent
     In the instance declaration for
        Embed (AlonzoUTXO era) (AlonzoUTXOW era)
    |
450 |   ( Era era,
    |   ^^^^^^^^^^...

src/Cardano/Ledger/Alonzo/Rules/Ledger.hs:114:1: warning: [-Wmissing-methods]
     No explicit associated type or default declaration for Event
     In the instance declaration for STS (AlonzoLEDGER era)
    |
114 | instance
    | ^^^^^^^^...

src/Cardano/Ledger/Alonzo/Rules/Ledger.hs:168:3: warning: [-Wmissing-methods]
     No explicit implementation for
        wrapEvent
     In the instance declaration for
        Embed (DELEGS era) (AlonzoLEDGER era)
    |
168 |   ( Era era,
    |   ^^^^^^^^^^...

src/Cardano/Ledger/Alonzo/Rules/Ledger.hs:177:3: warning: [-Wmissing-methods]
     No explicit implementation for
        wrapEvent
     In the instance declaration for
        Embed (AlonzoUTXOW era) (AlonzoLEDGER era)
    |
177 |   ( Era era,
    |   ^^^^^^^^^^...

src/Cardano/Ledger/Alonzo/Rules/Ledger.hs:186:3: warning: [-Wmissing-methods]
     No explicit implementation for
        wrapEvent
     In the instance declaration for
        Embed (AlonzoLEDGER era) (Shelley.LEDGERS era)
    |
186 |   ( Era era,
    |   ^^^^^^^^^^...

CC @goolord

@goolord
Copy link
Contributor

goolord commented Jun 24, 2021

I opened a pr to revert the change, I think I need to restructure the event log pr a bit to implement some of these instances. Sorry about the inconvenience, I don't know how I didn't catch this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants