Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Event Log" #2356

Merged
merged 1 commit into from
Jun 24, 2021
Merged

Revert "Event Log" #2356

merged 1 commit into from
Jun 24, 2021

Conversation

goolord
Copy link
Contributor

@goolord goolord commented Jun 24, 2021 •
edited
Loading

Reverts #2244

resolves #2354

@goolord
Copy link
Contributor Author

goolord commented Jun 24, 2021 •
edited
Loading

in the current implementation of the event log

  • the way the modules are organized makes some instances of Embed/wrapEvent impossible to implement
  • many functions use type equality constraints to be polymorphic over STS, which doesn't work well with an associated data family like this
  • some new instances slipped past me when I merged the event log pr

I need to rethink the event log pr.
Apologies for any inconvenience I may have caused.

JaredCorduan
JaredCorduan approved these changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@goolord
Revert "Add event log"
316127f 
This reverts commit 0128d81.
@JaredCorduan JaredCorduan merged commit ad92c15 into master Jun 24, 2021
@iohk-bors iohk-bors bot deleted the revert-2244-event-logger branch June 24, 2021 21:05
@goolord goolord mentioned this pull request Jul 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaredCorduan JaredCorduan JaredCorduan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing implementation for STS class methods
2 participants
@goolord @JaredCorduan