Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add invalid UTxO to the conformance tests #788

Closed
dnadales opened this issue Aug 22, 2019 · 0 comments · Fixed by #865
Closed

Add invalid UTxO to the conformance tests #788

dnadales opened this issue Aug 22, 2019 · 0 comments · Fixed by #865
Assignees
@mhuesch
Labels
byron ⚙️ executable-model

Comments

@dnadales
Copy link
Member

Update ts_prop_invalidBlocksAreRejected in module Test.Cardano.Chain.Block.Model so that the failureProfile includes the invalid UTxO generators:

ts_prop_invalidBlocksAreRejected :: TSProperty
ts_prop_invalidBlocksAreRejected =
  withTestsTS 400  $ property $ do
    let traceLength = 100 :: Word64
    tr <- forAll $ invalidTrace @CHAIN traceLength failureProfile

...

    failureProfile :: [(Int, SignalGenerator CHAIN)]
    failureProfile = [ (1, invalidDelegationGen)
                     , (1, invalidUpdateProposalGen)

Alternatively, unfold ts_prop_invalidBlocksAreRejected into three separate tests:

  • ts_prop_invalidDelegationCertificatesAreRejected
  • ts_prop_invalidUpdatesAreRejected
  • ts_prop_invalidUTxOTransactionsAreRejected

... or something like that.
@mhuesch mhuesch mentioned this issue Sep 3, 2019
Closed
mhuesch added a commit that referenced this issue Sep 4, 2019
@mhuesch
[#788][#817] Add goblins to signal tampering functions
cacf4bd
@mhuesch mhuesch added this to the Invalid chain conformance tests milestone Sep 12, 2019
mhuesch added a commit that referenced this issue Sep 18, 2019
@mhuesch
[#788][#817] Add goblins to signal tampering functions
8431c01
mhuesch added a commit that referenced this issue Sep 19, 2019
@mhuesch
[#788][#817] Introduce newtypes to wrap types with implicit bounds
318f809 
This allows Goblin instances to be written to respect said bounds, so that we
can avoid generating invalid values which case runtime exceptions in the
test-suite.
mhuesch added a commit that referenced this issue Sep 19, 2019
@mhuesch
[#788][#817] Ensure that Goblins Tx types will never be empty lists
a3acaba
mhuesch added a commit that referenced this issue Sep 19, 2019
@mhuesch
[#788][#817] Tweak Goblin instances & coverage checks for conformance…
8e4033c 
… tests
This was referenced Sep 19, 2019
Merged
Merged
mhuesch added a commit that referenced this issue Sep 19, 2019
@mhuesch
[#788][#817] Introduce newtypes to wrap types with implicit bounds
06cb00b 
This allows Goblin instances to be written to respect said bounds, so that we
can avoid generating invalid values which case runtime exceptions in the
test-suite.
mhuesch added a commit that referenced this issue Sep 19, 2019
@mhuesch
[#788][#817] Ensure that Goblins Tx types will never be empty lists
b032048
mhuesch added a commit that referenced this issue Sep 19, 2019
@mhuesch
[#788][#817] Tweak Goblin instances & coverage checks for conformance…
3635c01 
… tests
mhuesch added a commit that referenced this issue Sep 19, 2019
@mhuesch
[#788][#817] Set up for DCert conformance testing
d4b9d54
mhuesch added a commit that referenced this issue Sep 20, 2019
@mhuesch
[#788][#817] Add goblins to signal tampering functions
e0c3609
mhuesch added a commit that referenced this issue Sep 20, 2019
@mhuesch
[#788][#817] Introduce newtypes to wrap types with implicit bounds
884dd34 
This allows Goblin instances to be written to respect said bounds, so that we
can avoid generating invalid values which case runtime exceptions in the
test-suite.
mhuesch added a commit that referenced this issue Sep 20, 2019
@mhuesch
[#788][#817] Ensure that Goblins Tx types will never be empty lists
bb9e00b
mhuesch added a commit that referenced this issue Sep 20, 2019
@mhuesch
[#788][#817] Tweak Goblin instances & coverage checks for conformance…
36eb03e 
… tests
mhuesch added a commit that referenced this issue Sep 20, 2019
@mhuesch
[#788][#817] Set up for DCert conformance testing
ac2dd94
mhuesch added a commit that referenced this issue Sep 20, 2019
@mhuesch
[#788][#817] Address PR feedback
a75fce0 
- Use lovelaceCap from GlobalParams
- Remove `modulate` local defn, fix alignment
iohk-bors bot added a commit to input-output-hk/cardano-ledger-byron that referenced this issue Sep 20, 2019
@iohk-bors @mhuesch
Merge #636
c9fcfa4 
636: Integrate goblins into the conformance tests r=mhuesch a=mhuesch

We add a `ts_prop_invalidTxWitsAreRejected` conformance property to `Test.Cardano.Chain.Block.Model`. Adding this property required reworking of a number of types in `cardano-ledger-specs` to capture bounds which were not previously "knowable" from the type of the value.

***

This relates to IntersectMBO/cardano-ledger#788 & IntersectMBO/cardano-ledger#817.

Co-authored-by: Michael Hueschen <michaelhueschen@gmail.com>
kevinhammond pushed a commit that referenced this issue Oct 28, 2019
@mhuesch
[#788][#817] Add goblins to signal tampering functions
cb9a821
kevinhammond pushed a commit that referenced this issue Oct 28, 2019
@mhuesch
[#788][#817] Introduce newtypes to wrap types with implicit bounds
6e3dede 
This allows Goblin instances to be written to respect said bounds, so that we
can avoid generating invalid values which case runtime exceptions in the
test-suite.
kevinhammond pushed a commit that referenced this issue Oct 28, 2019
@mhuesch
[#788][#817] Ensure that Goblins Tx types will never be empty lists
9708748
kevinhammond pushed a commit that referenced this issue Oct 28, 2019
@mhuesch
[#788][#817] Tweak Goblin instances & coverage checks for conformance…
71467e0 
… tests
kevinhammond pushed a commit that referenced this issue Oct 28, 2019
@mhuesch
[#788][#817] Set up for DCert conformance testing
2adda8f
kevinhammond pushed a commit that referenced this issue Oct 28, 2019
@mhuesch
[#788][#817] Address PR feedback
b782e30 
- Use lovelaceCap from GlobalParams
- Remove `modulate` local defn, fix alignment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhuesch mhuesch

Labels
byron ⚙️ executable-model
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Integrate goblins into the conformance tests IntersectMBO/cardano-ledger
2 participants
@dnadales @mhuesch