SRE-36 haskell overhaul #1194
Merged
SRE-36 haskell overhaul #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nc6
previously requested changes
Feb 10, 2020
jbgi
force-pushed
the
SRE-36_haskell_overhaul
branch
from
af251fc
to
5ae88c4
Compare
craigem
requested review from
dnadales,
JaredCorduan and
mgudemann
as code owners
jbgi
force-pushed
the
SRE-36_haskell_overhaul
branch
6 times, most recently
from
bb90663
to
9bf0d78
Compare
disassembler
force-pushed
the
SRE-36_haskell_overhaul
branch
2 times, most recently
from
3ecf06f
to
3c5283e
Compare
jbgi
force-pushed
the
SRE-36_haskell_overhaul
branch
2 times, most recently
from
13545cf
to
3d6f81b
Compare
jbgi
force-pushed
the
SRE-36_haskell_overhaul
branch
from
3d6f81b
to
ca2cdd2
Compare
disassembler
approved these changes
Feb 13, 2020
|
bors r+ |
|
👎 Rejected by code reviews |
dcoutts
approved these changes
Feb 13, 2020
dcoutts
dismissed
nc6’s stale review
I'm satisfied that the review comments have now been addressed.
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 13, 2020
1194: SRE-36 haskell overhaul r=disassembler a=craigem This is the overhaul of Haskell for `cardano-ledger-specs` along the lines of `cardano-node` [PR #507](IntersectMBO/cardano-node#507). Co-authored-by: Craige McWhirter <craige.mcwhirter@iohk.io>
Build failed |
|
bors retry |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 13, 2020
1194: SRE-36 haskell overhaul r=disassembler a=craigem This is the overhaul of Haskell for `cardano-ledger-specs` along the lines of `cardano-node` [PR #507](IntersectMBO/cardano-node#507). Co-authored-by: Craige McWhirter <craige.mcwhirter@iohk.io>
|
bors r- |
Canceled |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 13, 2020
1194: SRE-36 haskell overhaul r=disassembler a=craigem This is the overhaul of Haskell for `cardano-ledger-specs` along the lines of `cardano-node` [PR #507](IntersectMBO/cardano-node#507). Co-authored-by: Craige McWhirter <craige.mcwhirter@iohk.io>
Build failed |
|
bors r+ |
|
bors r- |
Canceled |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 14, 2020
1194: SRE-36 haskell overhaul r=disassembler a=craigem This is the overhaul of Haskell for `cardano-ledger-specs` along the lines of `cardano-node` [PR #507](IntersectMBO/cardano-node#507). Co-authored-by: Craige McWhirter <craige.mcwhirter@iohk.io>
|
bors r- |
|
bors r+ |
Canceled |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 14, 2020
1194: SRE-36 haskell overhaul r=disassembler a=craigem This is the overhaul of Haskell for `cardano-ledger-specs` along the lines of `cardano-node` [PR #507](IntersectMBO/cardano-node#507). Co-authored-by: Craige McWhirter <craige.mcwhirter@iohk.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the overhaul of Haskell for
cardano-ledger-specsalong the lines ofcardano-nodePR #507.