Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup address deserialization #3218

Merged
merged 15 commits into from Dec 20, 2022
Merged

Cleanup address deserialization #3218

merged 15 commits into from Dec 20, 2022

Commits on Dec 19, 2022

  1. Move BaseTypes tests into core test suite

    @lehins
    lehins committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    91cb8da View commit details
    Browse the repository at this point in the history

  2. Start new test suite for cardano-ledger-core using hspec. Adopt BaseT… 

    …ypes tests
    @lehins
    lehins committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    0929d56 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2022

  1. Move CompactAddr tests over to cardano-ledger-core:test

    @lehins
    lehins committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    bead32a View commit details
    Browse the repository at this point in the history

  2. Enforce all roundtrip tests to check all versions

    @lehins
    lehins committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    98a0e65 View commit details
    Browse the repository at this point in the history

  3. Extract older address decompaction logic into the test library 

    * Also add roundtrip for CompactAddr
    @lehins
    lehins committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    e044c22 View commit details
    Browse the repository at this point in the history

  4. Ensure decompacting an address does not blow up on addresses with gar… 

    …bage
    @lehins
    lehins committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    67d4f01 View commit details
    Browse the repository at this point in the history

  5. Stop exporting CompactAddr constructor in order to improve safety

    @lehins
    lehins committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    4aca767 View commit details
    Browse the repository at this point in the history

  6. Add check that decompacting is still the same

    @lehins
    lehins committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    f5b26a2 View commit details
    Browse the repository at this point in the history

  7. Rename CompactAddress to CommonAddr

    @lehins
    lehins committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    6e83a7d View commit details
    Browse the repository at this point in the history

  8. Rename Address to CommonAddr

    @lehins
    lehins committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    63a9f82 View commit details
    Browse the repository at this point in the history

  9. Merge CompactAddress and Address into one module

    @lehins
    lehins committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    6489deb View commit details
    Browse the repository at this point in the history

  10. Final step in combining CompactAddress and Address modules togeth… 

    …er. Deprecate the former
    @lehins
    lehins committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    436f2d5 View commit details
    Browse the repository at this point in the history

  11. Move the last of Addr deserializer into testing.

    @lehins
    lehins committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    4f80048 View commit details
    Browse the repository at this point in the history

  12. Switch Addr decoding in Babbage to FromCBOR instance

    @lehins
    lehins committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    4296509 View commit details
    Browse the repository at this point in the history

  13. Exclude byron version from roundtrip testing. Update changelog.

    @lehins
    lehins committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    7236776 View commit details
    Browse the repository at this point in the history