version the new cost model deserializers #3274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodanciu
reviewed
Jan 31, 2023
teodanciu
reviewed
Jan 31, 2023
teodanciu
reviewed
Jan 31, 2023
eras/alonzo/test-suite/test/Test/Cardano/Ledger/Alonzo/Serialisation/CDDL.hs
Show resolved
Hide resolved
JaredCorduan
force-pushed
the
jc/version-new-cost-model-deserializers
branch
from
2764c16
to
31b9e5b
Compare
Enforce that the cost model deserializers prior to version 9 use a list of the expected length.
JaredCorduan
force-pushed
the
jc/version-new-cost-model-deserializers
branch
from
31b9e5b
to
a1c06fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enforce that the cost model deserializers prior to version 9 use a list of the expected length. This is required for full backwards compatibility (otherwise the current deserializers in ledger are more flexible than those currently used by the node).
Note that the
conwayCDDL file has been changed to reflect this change (and thus the CDDL tests as well).This is the last changed needed to resolve #2902.In order to resolve #2902, we still need to support deserializing cost models for future version of Plutus (we do now support adding new builtins).Checklist
fourmolu(which can be run withscripts/fourmolize.sh