Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP Change STS from LEDGER down to use ILC Diff #3364

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

WIP Change STS from LEDGER down to use ILC Diff #3364

wants to merge 1 commit into from

Conversation

TimSheard
Copy link
Contributor

@TimSheard TimSheard commented Mar 30, 2023 •
edited

Change the STS instanced from LEDGER down to use ILC Diffs for the STS State type family.
So far we have added

  1. The ILC class
  2. ILC instances for Coin, UMap, DPState, DState, PState, InstantaneousRewards
  3. Added a bunch of property tests

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the CHANGELOG.md for affected package
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@TimSheard
Copy link
Contributor Author

Here is a picture of what we are trying to do
Untitled presentation

@TimSheard
Added Data.Incremental with class(ILC) and basic instances (Map,Monoi…
25664e1 
…dMap,Total) tests.

Added ILC instances for Core: Coin, UMap, DPState, DState, PState, UTxOState etc.
Added ILC instances for (Diff DPState), (Diff DState) (Diff UTxOstate) etc.
Add property tests for ILC invariants for every ILC instance.
Rewrote the "POOL" STS rule to use differences (Diff PState), and all the POOL tests
Added the Conway era HSpec test directory:  eras/conway/impl/test
@JaredCorduan JaredCorduan marked this pull request as draft May 10, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Soupstraw Soupstraw Soupstraw left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TimSheard @Soupstraw