Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index aware PlutusPurpose #3996

Merged
merged 6 commits into from
Feb 1, 2024
Merged

Index aware PlutusPurpose #3996

merged 6 commits into from
Feb 1, 2024

Conversation

lehins
Copy link
Contributor

@lehins lehins commented Jan 17, 2024

Description

  • Add AsIxItem, which allows us having a PlutusPurpose be both item and index aware, thus avoiding the reverse lookup of an item in order to find its index.
  • Fix ConwayTxBody pattern synonym, by changing its certificates arguments to OSet
    from a StrictSeq
  • Add SpendingPurpose, MintingPurpose, CertifyingPurpose, RewardingPurpose,
    VotingPurpose and ProposingPurpose pattern synonyms to allow era agnostic handling of PlutusPurpose

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@lehins lehins force-pushed the lehins/script-purpose-index-aware branch 3 times, most recently from 83736e5 to 9c790f0 Compare January 24, 2024 17:27
@lehins lehins force-pushed the lehins/script-purpose-index-aware branch 2 times, most recently from 81ae580 to f982242 Compare January 31, 2024 09:50
@lehins lehins marked this pull request as ready for review January 31, 2024 09:50
@lehins lehins force-pushed the lehins/script-purpose-index-aware branch from 22acc70 to ecd291a Compare January 31, 2024 12:18
@lehins lehins force-pushed the lehins/script-purpose-index-aware branch 2 times, most recently from 0a3a4d5 to 0f31a38 Compare January 31, 2024 17:30
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🤯

@lehins lehins mentioned this pull request Feb 1, 2024
@lehins lehins force-pushed the lehins/script-purpose-index-aware branch from 0f31a38 to 3da36fa Compare February 1, 2024 14:07
@lehins lehins enabled auto-merge February 1, 2024 16:43
@lehins lehins merged commit b283c02 into master Feb 1, 2024
10 of 26 checks passed
@neilmayhew neilmayhew deleted the lehins/script-purpose-index-aware branch March 8, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants