Rename Acnt -> Account
#4002
Merged
Rename Acnt -> Account
#4002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lucsanszky
force-pushed
the
lucsanszky/rename-acnt
branch
2 times, most recently
from
5dd66d2
to
1db34ec
Compare
lehins
reviewed
Jan 23, 2024
Lucsanszky
force-pushed
the
lucsanszky/rename-acnt
branch
2 times, most recently
from
c18a30c
to
c4a86e1
Compare
|
Sorry for the rebase after (pre-)review but I wanted to keep the commits organised so we can easily revert if need be. Also, I found some more instances of |
Lucsanszky
force-pushed
the
lucsanszky/rename-acnt
branch
2 times, most recently
from
92a1c56
to
58f6682
Compare
|
This is now ready for review. I tried to keep the commits as organised as possible. I also attempted to keep changes separate, except for the final commit (f51ed29): that was used to rename some internal stuff for consistency and since those are internal, not exported things, I didn't add deprecation helpers for them. I am also quite certain that I missed a few things here and there. |
Lucsanszky
force-pushed
the
lucsanszky/rename-acnt
branch
from
58f6682
to
f51ed29
Compare
lehins
requested changes
Jan 25, 2024
libs/cardano-ledger-core/testlib/Test/Cardano/Ledger/Core/KeyPair.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-core/testlib/Test/Cardano/Ledger/Core/KeyPair.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Generic/PrettyCore.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Vars.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/TypeRep.hs
Outdated
Show resolved
Hide resolved
Lucsanszky
force-pushed
the
lucsanszky/rename-acnt
branch
11 times, most recently
from
621f5f3
to
e8ce02a
Compare
|
With respect to failing CI, it is unrelated to your changes. Both are flaky tests, one of which I already have a fix for. |
Lucsanszky
force-pushed
the
lucsanszky/rename-acnt
branch
from
e8ce02a
to
e057ab4
Compare
Renamed to `RewardAccount`
Renamed to `serialiseRewardAccount`
Renamed to `deserialiseRewardAccount`
Renamed to `putRewardAccount`
Renamed to `decodeRewardAccount`
Renamed to `fromCborRewardAccount`
Renamed to `ppRewardAccount`
Renamed to `prAccountState`
* `getRwdNetwork` -> `raNetwork` * `getRwdCred` -> `raCredential` Co-authored-by: Alexey Kuleshevich <alexey.kuleshevich@iohk.io>
Renamed to `mkVKeyRewardAccount` Co-authored-by: Alexey Kuleshevich <alexey.kuleshevich@iohk.io>
Renamed to `delPlAccount`
Renamed to `deserialiseRewardAccountOld`
It seems that these are only used internally, hence no deprecation helpers.
lehins
force-pushed
the
lucsanszky/rename-acnt
branch
from
e057ab4
to
d4e8bb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR renames
AcnttoAccountby deprecating the following:prAcntppRewardAcntfromCborRewardAcntdecodeRewardAcntputRewardAcntdeserialiseRewardAcntserialiseRewardAcntRewardAcntdeserialiseRewardAcntOlddelPlAcntmkVKeyRwdAcntFurthermore, the PR also renames some occurrences of
acntfor consistency, without any deprecation helpers (as these are just internal functions or helpers, etc.).Resolves #3928
Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)