Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare ledger release #4011

Merged
merged 6 commits into from
Jan 26, 2024
Merged

Prepare ledger release #4011

merged 6 commits into from
Jan 26, 2024

Conversation

lehins
Copy link
Contributor

@lehins lehins commented Jan 25, 2024

Description

This PR includes various fixups needed for the next release to CHaPs, as well as the follow up task of updating Changelogs

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@lehins lehins force-pushed the lehins/post-release-changes branch 2 times, most recently from 0c4d98b to 9237e00 Compare January 25, 2024 12:40
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, great that the CHaP build is passing.

@lehins
Copy link
Contributor Author

lehins commented Jan 25, 2024

Looks like CI caught a bug at the very last minute. I'll have to redo the release once we fix it.
CC. @aniketd

Copy link
Contributor

@Soupstraw Soupstraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lehins lehins force-pushed the lehins/post-release-changes branch from 9237e00 to 693466c Compare January 26, 2024 01:03
@lehins lehins enabled auto-merge January 26, 2024 09:02
@lehins lehins merged commit 57d2e81 into master Jan 26, 2024
9 of 39 checks passed
@lehins
Copy link
Contributor Author

lehins commented Jan 26, 2024

Looks like CI caught a bug at the very last minute. I'll have to redo the release once we fix it.

I decided to make a release regardless of this bug. We'll make a patch release for cardano-ledger-conway, once we squash it.

@neilmayhew neilmayhew deleted the lehins/post-release-changes branch March 8, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants