Remove ConwayPool
rule definition
#4065
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Conway's
POOL
is identical to the one in Shelley. There is no need to redefine it.This PR removes
ConwayPool
in favor ofShelleyPOOL
It also:
ShelleyTx
in Shelley and Allegra rules in favor ofTx
type familyEraRule rule era
invective in therule
. This will help avoid mistakes like this:Unfortunately it can't be made injective in
era
as well, because ofTICKN
:cardano-ledger/eras/shelley-ma/test-suite/test/Tests.hs
Lines 34 to 36 in 0e65b5e
Maybe in the future will be able to solve that one, which will help with type inference
Checklist
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.md
for the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)