Add ConwayUtxosPredFailure
#4150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
force-pushed
the
lehins/ConwayUtxosPredFailure
branch
from
a61abb5
to
8e62a04
Compare
lehins
force-pushed
the
lehins/ConwayUtxosPredFailure
branch
from
d4bc153
to
6236622
Compare
lehins
force-pushed
the
lehins/ConwayUtxosPredFailure
branch
from
6236622
to
3bc27d7
Compare
9 tasks
Conway no longer has `PPUP` rule, so we need to use a predicate failure that doesn't contain a predicate failure for that rule
Unfortunately we can't fix this problem for Babbage era, because that would break the node-to-client protocol. So, we need to wait until we are in Conway to fix this serialization issue with `PlutusPurpose`. With respect to fixing this problem for Conway, this is already done. It has been fixed with introduction of `ConwayPlutusPurpose` type in #3960
lehins
force-pushed
the
lehins/ConwayUtxosPredFailure
branch
from
3bc27d7
to
5264b82
Compare
This was referenced Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduced new predicate failure
ConwayUtxosPredFailurethat does not containPPUPpredicate failuresAlso supersedes and resuses work from #4103
Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)