Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert small-steps-test into a sublibrary #4174

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Convert small-steps-test into a sublibrary #4174

merged 1 commit into from
Mar 8, 2024

Conversation

Lucsanszky
Copy link
Contributor

@Lucsanszky Lucsanszky commented Mar 6, 2024 •
edited

Description

Resolves #4068

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@Lucsanszky Lucsanszky force-pushed the lucsanszky/small-steps-test-sublib branch from 3d4b88d to a5241a1 Compare March 7, 2024 02:24
@Lucsanszky Lucsanszky changed the title Convert small-steps-step into a sublibrary Convert small-steps-test into a sublibrary Mar 7, 2024
@Lucsanszky Lucsanszky force-pushed the lucsanszky/small-steps-test-sublib branch 2 times, most recently from a2b989b to 804f0b1 Compare March 7, 2024 03:22
@Lucsanszky Lucsanszky marked this pull request as ready for review March 7, 2024 03:23
@Lucsanszky Lucsanszky force-pushed the lucsanszky/small-steps-test-sublib branch from 804f0b1 to eb8ce30 Compare March 7, 2024 03:36
@Lucsanszky Lucsanszky force-pushed the lucsanszky/small-steps-test-sublib branch from eb8ce30 to 327ddcd Compare March 8, 2024 00:34
lehins
lehins approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!!
One less package to worry about!

@lehins lehins force-pushed the lucsanszky/small-steps-test-sublib branch from 327ddcd to 0768115 Compare March 8, 2024 10:45
@lehins lehins enabled auto-merge March 8, 2024 10:46
@lehins lehins force-pushed the lucsanszky/small-steps-test-sublib branch from 0768115 to 84bfa13 Compare March 8, 2024 12:56
@lehins lehins merged commit a13e552 into master Mar 8, 2024
14 of 16 checks passed
@neilmayhew neilmayhew deleted the lucsanszky/small-steps-test-sublib branch March 8, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lehins lehins lehins approved these changes

@teodanciu teodanciu Awaiting requested review from teodanciu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert small-steps-test into a sublibrary
3 participants
@Lucsanszky @teodanciu @lehins