Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CARDANO_MAINNET_MIRROR to Nix shell #4176

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

ana-pantilie
Copy link
Contributor

Description

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@lehins lehins force-pushed the ana/add-mainnetepochs-to-shell branch from a1c9c2b to 1697da6 Compare March 7, 2024 14:59
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks

README.md Show resolved Hide resolved
@lehins
Copy link
Contributor

lehins commented Mar 8, 2024

I'll merge this PR when we are ready.
FYI. We normally do not let merge commits into feature branches and ask to rebase on master instead. There is a feature in the UI for this as well "Update with rebase":

image

Signed-off-by: Ana Pantilie <ana.pantilie95@gmail.com>
@lehins lehins force-pushed the ana/add-mainnetepochs-to-shell branch from 6439383 to ef527d2 Compare March 8, 2024 10:37
@lehins lehins enabled auto-merge (squash) March 8, 2024 10:37
@ana-pantilie
Copy link
Contributor Author

@lehins Sorry, thank you for fixing it! I'll make sure to remember this for future PRs.

@lehins
Copy link
Contributor

lehins commented Mar 8, 2024

@ana-pantilie No worries, you had no way of knowing. I only pointed it out for the future.
Thank you for submitting this PR.

@lehins lehins merged commit 2e6bd4f into master Mar 8, 2024
15 checks passed
@neilmayhew neilmayhew deleted the ana/add-mainnetepochs-to-shell branch March 15, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants