Fix prop_GOV so that it runs again
#4200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaximilianAlgehed
force-pushed
the
PR-fix-prop_GOV
branch
4 times, most recently
from
92b8fbd
to
ae64883
Compare
MaximilianAlgehed
force-pushed
the
PR-fix-prop_GOV
branch
from
dcfaae2
to
12f3b5a
Compare
`HasSimpleRep` and using `caseOn` - selector functions - found and fixed bug in `conformsTo` for rose trees - fixes to the common subexpression elimination, and a new test - add benchmarks - ignore profiling products in gitignore - a 50x improvement in map generation performance - fix issue with map generator not generating non-empty maps (weirdly enough!) - Add extractFn to Member class to simplify matching on function symbols - get rid of dead code + use uniqueness of vars more heavily - better cost centers - add listSumPair benchmark for the future - prettyprinting fix - Optimise the structure of `OneofL` to reduce the number of allocations - get rid of some unecessary calls to `freeVars` - export mkUnsafeProposals - add hints to list generation
MaximilianAlgehed
force-pushed
the
PR-fix-prop_GOV
branch
from
12f3b5a
to
0524f05
Compare
TimSheard
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Every thing looks good. It would be nice to record in the comments of the PR what changes were made for performance, and what changes were made to do the Proposals. Also It would be nice to see what was the overall improvement in time , and how each improvement contributed.
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/V2/Conway.hs
Show resolved
Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/V2/Conway.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/V2/Conway/GOV.hs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is kindof a big PR that uses the new
Treeextension toconstrained-generatorsto make sureprop_GOVticks.To make this work I had to make a bunch of performance improvements to
constrained-generatorsthat will hopefully be reflected in CI times going forward.Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)