Added tests from a bug report #4207

Soupstraw · 2024-03-19T16:07:17Z

Description

Added some deserialization tests from #4198.

Commit sequence broadly makes sense and commits have useful messages
New tests are added if needed and existing tests are updated
When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
versioning process.
The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
Code is formatted with fourmolu (use scripts/fourmolize.sh)
Cabal files are formatted (use scripts/cabal-format.sh)
hie.yaml has been updated (use scripts/gen-hie.sh)
Self-reviewed the diff

lehins

Looks great.

Side note, I have no idea how to reproduce the bug in #4198 nor do I have any thoughts on how such behavior could be explained

eras/conway/impl/test/Test/Cardano/Ledger/Conway/BinarySpec.hs

libs/cardano-ledger-binary/src/Cardano/Ledger/Binary/Decoding.hs

libs/cardano-ledger-binary/src/Cardano/Ledger/Binary/Plain.hs

eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Binary/Bugs.hs

lehins

This doesn't exactly test the bug described in #4198, but it doesn't mean we can't keep this test around.

libs/cardano-ledger-binary/cardano-ledger-binary.cabal

Soupstraw changed the title ~~Added test for a deserialization bug~~ Added tests for a deserialization bug Mar 19, 2024

Soupstraw force-pushed the jj/collateral-deserialise-bug branch 2 times, most recently from 5c715f0 to 354161c Compare March 20, 2024 11:18

Soupstraw changed the title ~~Added tests for a deserialization bug~~ Added tests from a bug report Mar 22, 2024

lehins reviewed Apr 1, 2024

View reviewed changes

Soupstraw force-pushed the jj/collateral-deserialise-bug branch 5 times, most recently from 7322f7c to 900a896 Compare April 3, 2024 09:49

Soupstraw requested a review from lehins April 3, 2024 10:43

Soupstraw force-pushed the jj/collateral-deserialise-bug branch from 900a896 to 9473720 Compare April 3, 2024 10:44

lehins approved these changes Apr 3, 2024

View reviewed changes

libs/cardano-ledger-binary/cardano-ledger-binary.cabal Show resolved Hide resolved

Soupstraw force-pushed the jj/collateral-deserialise-bug branch 4 times, most recently from 9473720 to 431cc2f Compare April 4, 2024 11:04

Added test for a deserialization bug

7be10f5

Soupstraw force-pushed the jj/collateral-deserialise-bug branch from 431cc2f to 7be10f5 Compare April 4, 2024 11:05

Soupstraw merged commit 6edffa2 into master Apr 4, 2024
15 checks passed

Soupstraw deleted the jj/collateral-deserialise-bug branch April 4, 2024 14:52