Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to full formolu runs on CI #4235

Merged
merged 5 commits into from
Apr 3, 2024
Merged

Revert to full formolu runs on CI #4235

merged 5 commits into from
Apr 3, 2024

Conversation

lehins
Copy link
Contributor

@lehins lehins commented Apr 3, 2024

Description

We neet to run fourmolu on all files on CI, not just the changed modules.

Consider a PR that updates a fourmolu version. In such case there will be no Haskell files that have been updated, but formatting of many modules could have very well changed.

Few other minor fixes.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

Consider a PR that updates fourmolu version. In such case no
Haskell files have been updated, but formatting of many modules
could have very well changed.
Copy link
Contributor

@Soupstraw Soupstraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lehins lehins merged commit b933089 into master Apr 3, 2024
34 checks passed
@lehins lehins deleted the lehins/various-fixes branch April 3, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants