Fix strange CI failure. #4299
Merged
Fix strange CI failure. #4299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aniketd
force-pushed
the
aniketd/strange-ci-failure
branch
2 times, most recently
from
e87e31b
to
26f397f
Compare
lehins
approved these changes
Apr 25, 2024
The range of generated expired epochs and unexpired epochs overlaped at point 100, which caused the `genExpiredOrResigned` to assume that all `Yes` voting committee members are to be expired, but according to the spec we consider members expired only after the current epoch is greater than their expiry epoch, whereas in this case both were 100. The range of the generator has been adjusted according to these semantics.
lehins
force-pushed
the
aniketd/strange-ci-failure
branch
from
26f397f
to
bb46e8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The range of generated expired epochs and unexpired epochs overlaped at point 100, which caused the
genExpiredOrResignedto assume that allYesvoting committee members are to be expired, but according to the spec we consider members expired only after the current epoch is greater than their expiry epoch, whereas in this case both were 100.The range of the generator has been adjusted according to these semantics.
Fixes #4274
Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)