Complete EraScript hierarchy with missing classes
#4316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodanciu
force-pushed
the
td/shelley-allegra-erascript
branch
5 times, most recently
from
608da35
to
e9c20a6
Compare
teodanciu
force-pushed
the
td/shelley-allegra-erascript
branch
from
e9c20a6
to
0118714
Compare
teodanciu
changed the title
EraScript hierarchy with missing classes
teodanciu
force-pushed
the
td/shelley-allegra-erascript
branch
from
3d3d1e6
to
1c13467
Compare
lehins
reviewed
May 10, 2024
eras/shelley/impl/testlib/Test/Cardano/Ledger/Shelley/Arbitrary.hs
Outdated
Show resolved
Hide resolved
teodanciu
force-pushed
the
td/shelley-allegra-erascript
branch
14 times, most recently
from
ba2b044
to
f5a1251
Compare
teodanciu
force-pushed
the
td/shelley-allegra-erascript
branch
3 times, most recently
from
5818c4b
to
3a2379f
Compare
lehins
approved these changes
May 20, 2024
There was a problem hiding this comment.
There are quite a few places in testing where redundant constraint was specified (eg. NativeScript era ~ Timelock era). Such constraints are only really needed for creating class instances or whenever we need to enforce equality, like in validateMultiSig
Aside from that it looks great! Thank you!
eras/shelley/test-suite/test/Test/Cardano/Ledger/Shelley/MultiSigExamples.hs
Outdated
Show resolved
Hide resolved
eras/shelley/test-suite/test/Test/Cardano/Ledger/Shelley/MultiSigExamples.hs
Outdated
Show resolved
Hide resolved
eras/shelley/test-suite/test/Test/Cardano/Ledger/Shelley/MultiSigExamples.hs
Outdated
Show resolved
Hide resolved
eras/shelley/test-suite/test/Test/Cardano/Ledger/Shelley/MultiSigExamples.hs
Outdated
Show resolved
Hide resolved
eras/shelley/test-suite/test/Test/Cardano/Ledger/Shelley/MultiSigExamples.hs
Outdated
Show resolved
Hide resolved
eras/shelley-ma/test-suite/src/Test/Cardano/Ledger/AllegraEraGen.hs
Outdated
Show resolved
Hide resolved
eras/shelley-ma/test-suite/src/Test/Cardano/Ledger/AllegraEraGen.hs
Outdated
Show resolved
Hide resolved
eras/shelley-ma/test-suite/src/Test/Cardano/Ledger/AllegraEraGen.hs
Outdated
Show resolved
Hide resolved
eras/shelley-ma/test-suite/src/Test/Cardano/Ledger/Allegra/Examples/Consensus.hs
Outdated
Show resolved
Hide resolved
Replace era-specific patterns with new ones, constrained by the new EraScript classes, that build and access `NativeScript` instead of concrete types
teodanciu
force-pushed
the
td/shelley-allegra-erascript
branch
from
3a2379f
to
eda7693
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)