Specify numeric ranges explicitly in conway cddl files #4357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodanciu
force-pushed
the
td/improve-conway-cbor
branch
from
b636b0f
to
f0edf95
Compare
lehins
reviewed
May 24, 2024
teodanciu
force-pushed
the
td/improve-conway-cbor
branch
12 times, most recently
from
66d7813
to
e5b55d8
Compare
aniketd
reviewed
Jun 4, 2024
and name some common types. * Word16 -> uint .size 2 * Word32 -> uint .size 4 * Word64 -> uint .size 8 Define: epoch_interval, slot_no, block_no
to prevent exceeding the max size of the transaction
teodanciu
force-pushed
the
td/improve-conway-cbor
branch
from
e5b55d8
to
3d9fcc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and name some common types.
Define: epoch_interval, slot_no, block_no
Resolves #4296 #4360
Description
Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)