New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add update payload to chain traces #649
Merged
dnadales
merged 17 commits into
master
from
dnadales/621-add-update-payload-to-chain-traces
Jul 19, 2019
Merged
Changes from 13 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
c38a977
Limit the line width to 80.
dnadales 10812e9
Ignore `stack` lock file.
dnadales 2017878
Factor out functions for generating update proposal and votes, and en…
dnadales 96ad252
Fix arithmetic underflow when checking validity of proposed script ve…
dnadales a33188c
Fix the abstract size test ...
dnadales d071b62
Set a memory limit for the tests in `cs-blockchain`
dnadales f95acfb
Make the tests green again.
dnadales 7c2b33b
Tweak the coverage metrics to account for the fact that we do not wan…
dnadales 325cb01
Un-comment line I forgot
dnadales a389852
Generate `CHAIN` delegation payload only in 30% of the cases.
dnadales e7cf00a
Lower 10% the bounds for the "at least 10% of the proposals get enoug…
dnadales ec5330f
Reduce the number of tests in favor of longer chains.
dnadales c9d4453
Address Nick's remarks
dnadales b0bda7f
Guard the `newMaxBkSize - 1` against underflows
dnadales 2a7a9b4
Add TODO.
dnadales 31ba10e
Fix the update generator
dnadales 96d1951
- Lower the coverage threshold for "at least 10% of the update propos…
dnadales File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,6 +31,7 @@ | |
*~ | ||
dist-newstyle/ | ||
cabal.project.local | ||
stack.yaml.lock | ||
|
||
# Editors | ||
TAGS | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency, does this not want to be guarded in the same way with
shouldGenUpdate
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I was being lazy here since we generate update payload only sporadically, but you're right, we should try to adhere to the principle of least surprise :)