check reference inputs txins on dbsync #1521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saratomaz
force-pushed
the
check_reference_scripts_inputs_on_dbsync
branch
3 times, most recently
from
c0a9dfb
to
c188e88
Compare
mkoura
reviewed
Dec 22, 2022
mkoura
reviewed
Jan 4, 2023
|
Any update on this one? |
https://input-output-rnd.slack.com/archives/D02TNP64EPL/p1672939953700819 |
saratomaz
force-pushed
the
check_reference_scripts_inputs_on_dbsync
branch
from
c188e88
to
4bd6514
Compare
saratomaz
commented
May 16, 2023
saratomaz
force-pushed
the
check_reference_scripts_inputs_on_dbsync
branch
from
2931820
to
69961cb
Compare
mkoura
reviewed
May 23, 2023
saratomaz
force-pushed
the
check_reference_scripts_inputs_on_dbsync
branch
from
69961cb
to
e2f10e0
Compare
mkoura
reviewed
May 26, 2023
| @@ -153,6 +155,7 @@ class TxRecord(NamedTuple): | |||
| collateral_outputs: List[clusterlib.UTXOData] | |||
| reference_inputs: List[clusterlib.UTXOData] | |||
| scripts: List[ScriptRecord] | |||
| script_txins: List[ScriptRecord] | |||
There was a problem hiding this comment.
Wouldn't reference_scripts be more fitting name?
| cluster_obj.g_transaction.get_policyid(script_file=script_file) | ||
| ) | ||
|
|
||
| db_txins_script_hashes = {r.hash for r in response.script_txins if r.hash} |
There was a problem hiding this comment.
db_reference_script_hashes?
saratomaz
force-pushed
the
check_reference_scripts_inputs_on_dbsync
branch
from
e2f10e0
to
2097e89
Compare
saratomaz
force-pushed
the
check_reference_scripts_inputs_on_dbsync
branch
from
2097e89
to
de8a7a3
Compare
mkoura
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.