Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error message for incorrectly witnessed collateral inputs #4484

Merged
merged 2 commits into from
Sep 29, 2022

Conversation

Jimbo4350
Copy link
Contributor

Resolves: #4479

…ction build

command to construct transactions from prior eras
@Jimbo4350
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Sep 28, 2022
4484: Update error message for incorrectly witnessed collateral inputs r=Jimbo4350 a=Jimbo4350

Resolves: #4479 

Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 28, 2022

Timed out.

@Jimbo4350
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Sep 28, 2022
4466: Added changelogs for releases between 1.34.0 and 1.35.3 r=Jimbo4350 a=LaurenceIO

Updated api, cli, node, and submit-api changelogs on master with changes in 1.34.0, 1.34.1, 1.35.0, 1.35.1, 1.35.2, and 1.35.3 releases.

Thanks to `@ltouro` for highlighting a typo.

4484: Update error message for incorrectly witnessed collateral inputs r=Jimbo4350 a=Jimbo4350

Resolves: #4479 

4486: tx-generator: Use distinct keys/addresses for benchmarking phases r=MarcFontaine a=MarcFontaine

This is useful for debugging the tx-generator.
Hard coded addresses:
`addr_test1vzj7zv9msmdasvy5nc9jhnn2gqvrvu33v5rlg332zdfrkugklxkau` : outputs of the splitting phase (value not Plutus).
`addr_test1vz4qz2ayucp7xvnthrx93uhha7e04gvxttpnuq4e6mx2n5gzfw23z` : final outputs of the benchmarking phase.



Co-authored-by: LaurenceIO <73659683+LaurenceIO@users.noreply.github.com>
Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
Co-authored-by: MarcFontaine <MarcFontaine@users.noreply.github.com>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 28, 2022

This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried.

Additional information:

{"message":"Waiting on code owner review from MarcFontaine, cleverca22, deepfire, denisshevchenko, fmaste, jutaro, and/or mgmeier.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@Jimbo4350 Jimbo4350 merged commit 23b855d into master Sep 29, 2022
@iohk-bors iohk-bors bot deleted the jordan/4479-bug branch September 29, 2022 07:07
Jimbo4350 added a commit that referenced this pull request Sep 29, 2022
Update error message for incorrectly witnessed collateral inputs
disassembler pushed a commit that referenced this pull request Sep 29, 2022
Update error message for incorrectly witnessed collateral inputs
newhoggy pushed a commit that referenced this pull request Sep 29, 2022
Update error message for incorrectly witnessed collateral inputs
Jimbo4350 added a commit that referenced this pull request Oct 5, 2022
Update error message for incorrectly witnessed collateral inputs
Jimbo4350 added a commit that referenced this pull request Oct 5, 2022
Update error message for incorrectly witnessed collateral inputs
disassembler pushed a commit that referenced this pull request Oct 25, 2022
Update error message for incorrectly witnessed collateral inputs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - misleading error message - transaction build reports locked input as not locked
2 participants