Release 1.35.4 #4508
Merged
Release 1.35.4 #4508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
requested review from
deepfire,
denisshevchenko,
jutaro,
coot,
mgmeier,
MarcFontaine,
cleverca22,
dcoutts,
erikd,
newhoggy and
JaredCorduan
as code owners
Jimbo4350
force-pushed
the
1.35-cli-secp
branch
3 times, most recently
from
7d5ad62
to
d5b3287
Compare
disassembler
approved these changes
Oct 6, 2022
Jimbo4350
force-pushed
the
1.35-cli-secp
branch
3 times, most recently
from
ff74bc9
to
e0719fd
Compare
collateral values when they are not explicitly specified via the cli
Previously the functions to read text envelopes used `readFile` from Data.ByteString. Unfortunately, that doesn't work with pipes, so we've switched to a function that does. Additionally, on unix based systems, we've changed how writing to an owned file works. Previously a new file was created (and since we created it, we must own it) and then copied into place. Unfortunately this doesn't work with symlinks, fifos, unix sockets or anything else that isn't a "normal" file. What we do now is grab the file descriptor, call fchown on it, which sets us as the owner (or errors out if we can't do that), and then write to the file.
in the ScriptContxt is equivalent to the mint field in our redeemer
It's desirable for a client to be able to predict the index of outputs. As such we append change to the end so that the index of other outputs doesn't changed based on whether there's change or not. Resolves #3725
Annoyingly I could not keep the explicit individual definitions + data instances exported so needed to reach for (..) and deduplicate exports.
There used to be no orphan instance for ledger Script so we (Hydra) provided our own. This newly introduced instance overlaps with our own which would not be a problem, as we are fine using upstream instances, but for the fact the serialisation is lossy as cardano-api only serialised the hash of the script.
Cardano.Api.Convenience.Query Cardano.Api.Convenience.Construction Cardano.Api.Convenience.Constraints This is the first stage of refactoring the transaction build command and simultaneously aims to expose a simplified interface to constructing and balancing a transaction. Move Cardano.CLI.Environment to Cardano.Api.Environment. We now reuse the SocketPath type throughout the cli and node
Remove SocketPath definition and textShow from cardano-submit-api Remove SocketPath definition from cardano-cli
Separate validation and construction of TxBodyContent Use queryStateForBalancedTx in runTxBuild Rename txInsExist to txInsExistInUTxO
Propagate textShow to cardano-cli Propagate textShow to cardano-node
…ction build command to construct transactions from prior eras
Update error message for incorrectly witnessed collateral inputs
Fix 4493 bug - essentially the type field in the Shelley era text envelope tx body was being written to disk as "TxWitnessShelley" and being read from disk as "TxWitness Shelley". I.e there was a mismatch and therefore it was not possible to read shelley era transaction bodies. Closes: #4493
When reading a key from a file, `readFile` from ByteString was used. Unfortunately this operation doesn't play nicely with pipes. We now use `openFileBlocking` so that we can wait for data which comes from a pipe. Fixes #4101
disassembler
force-pushed
the
1.35-cli-secp
branch
from
e0719fd
to
0c2d4bf
Compare
Closed
Jimbo4350
force-pushed
the
1.35-cli-secp
branch
from
0c2d4bf
to
8b89e75
Compare
disassembler
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.