Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: UTXO-HD for node 8.9.1 #5726

Open
wants to merge 28 commits into
base: utxo-hd-8.9-baseline
Choose a base branch
from
Open

Conversation

jasagredo
Copy link
Contributor

Description

Add your description here, if it fixes a particular issue please provide a
link
to the issue.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@jasagredo jasagredo requested review from a team as code owners March 25, 2024 15:10
@jasagredo jasagredo requested a review from a team as a code owner March 25, 2024 15:30
@@ -531,6 +577,9 @@ defaultPartialNodeConfiguration =
, pncTargetNumberOfActiveBigLedgerPeers = Last (Just 5)
, pncEnableP2P = Last (Just DisabledP2PMode)
, pncPeerSharing = Last (Just PeerSharingDisabled)
, pncSsdDatabaseDir = Last (Just "mainnet/ledgerdb/")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "mainnet" the correct language or path to bake-in at this point?

@dnadales dnadales mentioned this pull request Apr 12, 2024
20 tasks
Copy link

github-actions bot commented Jul 9, 2024

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants