Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove manual DRep registration from InfoAction test #5749

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

palas
Copy link
Contributor

@palas palas commented Apr 4, 2024

Description

This PR updates InfoAction test to not create its own DReps (this probably was not updated by #5732 because the test is commented out so it doesn't fail)

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

@palas palas added the minorfix Something that needs to be fixed (e.g. a hard-coded constant), but that isnt a bug label Apr 4, 2024
@palas palas self-assigned this Apr 4, 2024
@palas palas requested a review from a team as a code owner April 4, 2024 18:17
@palas palas added this pull request to the merge queue Apr 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 6, 2024
@palas palas added this pull request to the merge queue Apr 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 6, 2024
@palas palas added this pull request to the merge queue Apr 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 6, 2024
@palas palas force-pushed the fix-update-info-test branch 4 times, most recently from 81846e7 to 5bd9f8e Compare April 6, 2024 04:52
@palas palas requested review from a team as code owners April 6, 2024 04:52
@palas palas enabled auto-merge April 6, 2024 05:17
@palas palas disabled auto-merge April 8, 2024 16:13
@palas palas enabled auto-merge April 8, 2024 18:34
@palas palas added this pull request to the merge queue Apr 8, 2024
@palas palas removed this pull request from the merge queue due to a manual request Apr 8, 2024
@palas palas added this pull request to the merge queue Apr 8, 2024
@palas palas removed this pull request from the merge queue due to a manual request Apr 8, 2024
@palas palas enabled auto-merge April 8, 2024 19:40
@palas palas disabled auto-merge April 8, 2024 23:18
@palas palas enabled auto-merge April 8, 2024 23:19
@palas palas added this pull request to the merge queue Apr 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 9, 2024
@palas palas added this pull request to the merge queue Apr 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 9, 2024
@palas palas added this pull request to the merge queue Apr 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 9, 2024
@palas palas enabled auto-merge April 9, 2024 19:22
@palas palas disabled auto-merge April 9, 2024 23:41
@palas palas added this pull request to the merge queue Apr 10, 2024
Merged via the queue into master with commit d93f629 Apr 10, 2024
22 checks passed
@palas palas deleted the fix-update-info-test branch April 10, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minorfix Something that needs to be fixed (e.g. a hard-coded constant), but that isnt a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants