Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cl/integrate 9.0 #5895

Merged
merged 5 commits into from
Jul 3, 2024
Merged

Cl/integrate 9.0 #5895

merged 5 commits into from
Jul 3, 2024

Conversation

CarlosLopezDeLara
Copy link
Contributor

@CarlosLopezDeLara CarlosLopezDeLara commented Jul 1, 2024 •
edited
Loading

Description

Intermediate integration of node v9.0.0 with SRP

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@CarlosLopezDeLara CarlosLopezDeLara requested review from a team as code owners July 1, 2024 22:14
@CarlosLopezDeLara CarlosLopezDeLara marked this pull request as draft July 1, 2024 22:14
@disassembler disassembler force-pushed the cl/integrate-9.0 branch 3 times, most recently from 8bd5376 to 45a970b Compare July 3, 2024 04:15
@disassembler disassembler marked this pull request as ready for review July 3, 2024 04:16
Jimbo4350 and others added 3 commits July 3, 2024 12:59
@Jimbo4350 @carbolymer
Update npcExperimentalHardForksEnabled modification on Conway era: If
269a6de 
this flag is not present in the node's configuration, the node declates
it understand protocol version 9 (bootstrap era).

If the flag is present the node declares it understand protocol version
10 (useful to keep testing simpler).

(cherry picked from commit 908478e)
@CarlosLopezDeLara @carbolymer
Integrate node v9.0.0
86f3f7a
@carbolymer
Fix tx-generator error handling for new cardano-api
7b910f9
@disassembler disassembler merged commit 2820a63 into master Jul 3, 2024
21 checks passed
@disassembler disassembler deleted the cl/integrate-9.0 branch July 3, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disassembler disassembler disassembler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CarlosLopezDeLara @disassembler @Jimbo4350 @carbolymer