Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF cleanup 282: remove uncurry from code appearing in pdf #358

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

williamdemeo
Copy link
Contributor

Description

This is a requirement of issue #282.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Code is formatted according to CONTRIBUTING.md
  • Self-reviewed the diff

Copy link
Collaborator

@WhatisRT WhatisRT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the type of credVoter seems to be a pretty heavy solution for making documentation more accessible. I'm not necessarily against this change, but I'll need to think more about it.

@williamdemeo
Copy link
Contributor Author

Changing the type of credVoter seems to be a pretty heavy solution for making documentation more accessible.

I totally agree and that was exactly my sentiment as I was making that change. This was just the first approach that came to mind, but if you think of a better one, I'm open to suggestions. It certainly seems like it shouldn't be very hard to avoid calling uncurry; it's such a simple operation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants