Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require reference inputs to be disjoint from regular inputs #393

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Require reference inputs to be disjoint from regular inputs #393

merged 1 commit into from
Apr 17, 2024

Conversation

WhatisRT
Copy link
Collaborator

@WhatisRT WhatisRT commented Apr 15, 2024 •
edited

Description

Closes #354. This will also allow reference inputs in conformance tests.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Code is formatted according to CONTRIBUTING.md
  • Self-reviewed the diff

@WhatisRT WhatisRT requested a review from Soupstraw April 15, 2024 11:16
Soupstraw
Soupstraw approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@Soupstraw Soupstraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WhatisRT WhatisRT merged commit ea9a7fb into master Apr 17, 2024
3 checks passed
@WhatisRT WhatisRT deleted the andre/refinputs-disjoint branch April 17, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Soupstraw Soupstraw Soupstraw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disallow shared inputs between regular & reference
2 participants
@WhatisRT @Soupstraw