Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable basic PPUpdates #394

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Enable basic PPUpdates #394

merged 1 commit into from
Apr 17, 2024

Conversation

Soupstraw
Copy link
Contributor

Description

This PR makes it possible to create valid protocol parameter updates. Currently it is only possible to modify the a parameter.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Code is formatted according to CONTRIBUTING.md
  • Self-reviewed the diff

@Soupstraw Soupstraw requested a review from WhatisRT April 15, 2024 14:22
@Soupstraw Soupstraw force-pushed the jj/basic-ppupdate branch 5 times, most recently from b7b671b to f3593d3 Compare April 17, 2024 10:24
Copy link
Collaborator

@WhatisRT WhatisRT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I moved the proof to a better location

@WhatisRT WhatisRT merged commit ccca650 into master Apr 17, 2024
1 of 2 checks passed
@WhatisRT WhatisRT deleted the jj/basic-ppupdate branch April 17, 2024 11:09
WhatisRT added a commit that referenced this pull request Apr 17, 2024
@WhatisRT WhatisRT restored the jj/basic-ppupdate branch April 17, 2024 11:12
WhatisRT added a commit that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants