Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing *-step functions #426

Merged
merged 6 commits into from
May 23, 2024
Merged

Add missing *-step functions #426

merged 6 commits into from
May 23, 2024

Conversation

Soupstraw
Copy link
Contributor

Description

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Code is formatted according to CONTRIBUTING.md
  • Self-reviewed the diff

@Soupstraw Soupstraw force-pushed the jj/ratify-conformance branch 9 times, most recently from f0b42a3 to 3544ff6 Compare May 17, 2024 13:01
@Soupstraw Soupstraw marked this pull request as ready for review May 22, 2024 14:05
@Soupstraw Soupstraw changed the title RATIFY conformance Add missing *-step functions May 22, 2024
@Soupstraw Soupstraw requested a review from WhatisRT May 22, 2024 14:05
WhatisRT
WhatisRT approved these changes May 23, 2024
View reviewed changes
Copy link
Collaborator

@WhatisRT WhatisRT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, nice, you just did all of them? I rebased this and wait until at least one CI builds it before merging just to be safe.

@WhatisRT WhatisRT merged commit b9300f4 into master May 23, 2024
3 checks passed
@WhatisRT WhatisRT deleted the jj/ratify-conformance branch May 23, 2024 11:15
@WhatisRT WhatisRT mentioned this pull request May 23, 2024
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WhatisRT WhatisRT WhatisRT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Soupstraw @WhatisRT