Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#231] fix broken endpoints #232

Merged
merged 2 commits into from
Feb 20, 2024
Merged

[#231] fix broken endpoints #232

merged 2 commits into from
Feb 20, 2024

Conversation

jankun4
Copy link
Contributor

@jankun4 jankun4 commented Feb 20, 2024 •
edited by Sworzen1
Loading

fix endpoints broken due to assumption that predefined dreps always exist, even if noone delegated to them

List of changes

Fixed

  • proposal/list endpoint
  • network/metrics endpoint
  • drep/get-voting-power endpoint

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@jankun4
[#231] fix broken endpoints
1810742 
fix endpoints broken due to assumption that predefined dreps always exist, even if noone delegated to them
@jankun4 jankun4 linked an issue Feb 20, 2024 that may be closed by this pull request
Fix broken endpoints #231
Closed
MSzalowski
MSzalowski requested changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@MSzalowski MSzalowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pass info about these changes to changelog

Sworzen1
Sworzen1 previously approved these changes Feb 20, 2024
View reviewed changes
@jankun4
Copy link
Contributor Author

jankun4 commented Feb 20, 2024

Pass info about these changes to changelog

done

MSzalowski
MSzalowski approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@MSzalowski MSzalowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 🎉

@jankun4 jankun4 merged commit 5bdfcc0 into develop Feb 20, 2024
@jankun4 jankun4 deleted the 231-fix-broken-endpoints branch February 20, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSzalowski MSzalowski MSzalowski approved these changes

@Sworzen1 Sworzen1 Sworzen1 left review comments

@kickloop kickloop Awaiting requested review from kickloop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix broken endpoints
3 participants
@jankun4 @MSzalowski @Sworzen1