Query Constitution

[aniketd]

Description

Add GetConstitutionHash ledger query

Relates to cardano-ledger#3502

[lehins]

From my limited knowledge of the way ledger state queries work, this looks good.

[amesgen]

The query has to be gated behind a new ShelleyNodeToClientVersion:
https://github.com/input-output-hk/ouroboros-consensus/blob/1efac211d3691d4d26cb42218c2c7bc1cb8dae3d/ouroboros-consensus-cardano/src/shelley/Ouroboros/Consensus/Shelley/Ledger/Query.hs#L228-L229
See IntersectMBO/ouroboros-network#2830 for an example of how to do that; we do not yet have a nice "guide" for how to do this (which is tracked in #190, and we might have time to work on soon-ish, but not in the next few weeks).

• If this query is supposed to be experimental (i.e. it only should work when setting ExperimentalProtocolsEnabled: true in the node), then it is enough to just add a new ShelleyNodeToClientVersion and enable it via the experimental CardanoNodeToClientVersion12.

• If not, then a new NodeToClientVersion has to be added in Network, new {Shelley,Cardano}NodeToClientVersion have to be added here, and the NodeToClient part of latestReleasedNodeVersion has to be bumped.

[lehins]

Yes, this is experimental query that should only work in Conway

[aniketd]

@amesgen @lehins thanks for your inputs 🙌 🙇

[amesgen]

Looks good! Only minor comments below.

Can you also apply

diff --git a/ouroboros-consensus-cardano/src/shelley/Ouroboros/Consensus/Shelley/Ledger/NetworkProtocolVersion.hs b/ouroboros-consensus-cardano/src/shelley/Ouroboros/Consensus/Shelley/Ledger/NetworkProtocolVersion.hs
index ba04b8a8a..75443ad65 100644
--- a/ouroboros-consensus-cardano/src/shelley/Ouroboros/Consensus/Shelley/Ledger/NetworkProtocolVersion.hs
+++ b/ouroboros-consensus-cardano/src/shelley/Ouroboros/Consensus/Shelley/Ledger/NetworkProtocolVersion.hs
@@ -61,7 +61,7 @@ instance SupportedNetworkProtocolVersion (ShelleyBlock proto era) where
       , (NodeToClientV_13, ShelleyNodeToClientVersion5)
       , (NodeToClientV_14, ShelleyNodeToClientVersion6)
       , (NodeToClientV_15, ShelleyNodeToClientVersion7)
-      , (NodeToClientV_16, ShelleyNodeToClientVersion7)
+      , (NodeToClientV_16, ShelleyNodeToClientVersion8)
       ]
 
   latestReleasedNodeVersion = latestReleasedNodeVersionDefault

and accept the respective golden file changes?