Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Homogenize Shelley versions in Cardano NTC versions #862

Closed
nfrisby opened this issue Jan 4, 2024 · 0 comments · Fixed by #863
Closed

Homogenize Shelley versions in Cardano NTC versions #862

nfrisby opened this issue Jan 4, 2024 · 0 comments · Fixed by #863
Assignees
@amesgen
Labels
enhancement New feature or request

Comments

@nfrisby
Copy link
Contributor

nfrisby commented Jan 4, 2024

Currently CardanoNodeToClientVersion12 uses ShelleyNodeToClientVersion8 for Conway but ShelleyNodeToClientVersion7 for all previous Shelley-based eras.

This issue is to change it so that all Shelley-based eras advance to Shelley8 in Cardano12. (No previous Cardano NTC version uses heterogeneous Shelley NTC versions.

(We think this will be a 5 line PR.)

The intent is to avoiding complicating the downstream versioning logic in eg cardano-cli (IntersectMBO/cardano-api#403)

Related:

  • Query Constitution #191 (comment) - Esgen raised this idea in the original PR. Aniket's response can be resolved by using an additional mediating per-era type-class in the Consensus layer (which we already do for some other queries).
@nfrisby nfrisby added the enhancement New feature or request label Jan 4, 2024
@amesgen amesgen self-assigned this Jan 4, 2024
This was referenced Jan 4, 2024
Merged
Closed
@nfrisby nfrisby mentioned this issue Jan 4, 2024
Closed
github-merge-queue bot pushed a commit that referenced this issue Jan 12, 2024
@amesgen
Homogenize Shelley versions in Cardano NTC versions (#863)
14d6071 
Closes #862

Note that `CardanoNodeToClientVersion12` is experimental, so this change
does not impact backwards-compatibility.
@carbolymer carbolymer mentioned this issue Feb 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amesgen amesgen

Labels
enhancement New feature or request
Projects
Consensus Team Backlog
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Homogenize Shelley versions in Cardano NTC versions IntersectMBO/ouroboros-consensus
2 participants
@nfrisby @amesgen