Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BlockNo to AnchoredFragment #1578

Closed
edsko opened this issue Feb 5, 2020 · 3 comments
Closed

Add BlockNo to AnchoredFragment #1578

edsko opened this issue Feb 5, 2020 · 3 comments
Assignees
@edsko
Labels
byron Required for a Byron mainnet: replace the old core nodes with cardano-node consensus issues related to ouroboros-consensus technical debt
Milestone
S6 2020-02-13

Comments

@edsko
Copy link
Contributor

edsko commented Feb 5, 2020 •
edited

In a lot of places (including in the new header state, #1577) we are stuck in the edge case where we have an empty anchored fragment, which gives us a point, but no block number. We should fix this once and for all by adding the block number to the anchor as well.
@edsko edsko self-assigned this Feb 5, 2020
@edsko edsko added byron Required for a Byron mainnet: replace the old core nodes with cardano-node consensus issues related to ouroboros-consensus priority medium technical debt labels Feb 5, 2020
@edsko
Copy link
Contributor Author

edsko commented Feb 5, 2020

Marking as medium priority despite it also being technical debt as it hinders other improvements (currently #1577, but also #1544 would have benefited from it, as well as I'm sure other parts also).

@edsko edsko mentioned this issue Feb 5, 2020
Closed
@edsko
Copy link
Contributor Author

edsko commented Feb 5, 2020

This is part of the work on fixing #1571 .

edsko added a commit that referenced this issue Feb 5, 2020
@edsko
Update consensus for new anchor type
57fa326 
Closes #1578.
Closes #1584.
@edsko
Copy link
Contributor Author

edsko commented Feb 5, 2020

WIP PR at #1589.

edsko added a commit that referenced this issue Feb 6, 2020
@edsko
Add BlockNo to the anchor of an AnchoredFragment
4194775 
Closes #1578.
Closes #1584.
@iohk-bors iohk-bors bot closed this as completed in 299f638 Feb 6, 2020
@mrBliss mrBliss added this to the S6 2020-02-13 milestone Feb 6, 2020
@edsko edsko mentioned this issue Feb 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edsko edsko

Labels
byron Required for a Byron mainnet: replace the old core nodes with cardano-node consensus issues related to ouroboros-consensus technical debt
Projects
None yet
Milestone
S6 2020-02-13
Development

No branches or pull requests
2 participants
@mrBliss @edsko