Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mkCurrentBlockContext is still wrong #1584

Closed
edsko opened this issue Feb 5, 2020 · 2 comments
Closed

mkCurrentBlockContext is still wrong #1584

edsko opened this issue Feb 5, 2020 · 2 comments
Assignees
@edsko
Labels
bug Something isn't working byron Required for a Byron mainnet: replace the old core nodes with cardano-node consensus issues related to ouroboros-consensus
Milestone
S6 2020-02-13

Comments

@edsko
Copy link
Contributor

edsko commented Feb 5, 2020

The problem is that the chain DB pretends that there is a block number when the chain is at genesis, but there isn't. It picks genesisBlockNo, which is wrong, because that is the block number of the first block on the chain; in mkCurrentBlockContext we then take the successor of this block number, and so we end up skipping one.

Fixing this is part of #1571 , and I'm therefore marking it as high priority. The fix will be part of the work on #1578 .
@edsko edsko self-assigned this Feb 5, 2020
@edsko edsko added byron Required for a Byron mainnet: replace the old core nodes with cardano-node consensus issues related to ouroboros-consensus priority high bug Something isn't working labels Feb 5, 2020
@edsko
Copy link
Contributor Author

edsko commented Feb 5, 2020

(PR where we thought we fixed this was #1544).

edsko added a commit that referenced this issue Feb 5, 2020
@edsko
Update consensus for new anchor type
57fa326 
Closes #1578.
Closes #1584.
@edsko
Copy link
Contributor Author

edsko commented Feb 5, 2020

This will be fixed in #1589.

edsko added a commit that referenced this issue Feb 6, 2020
@edsko
Add BlockNo to the anchor of an AnchoredFragment
4194775 
Closes #1578.
Closes #1584.
@iohk-bors iohk-bors bot closed this as completed in 299f638 Feb 6, 2020
@mrBliss mrBliss added this to the S6 2020-02-13 milestone Feb 6, 2020
@mrBliss mrBliss mentioned this issue Feb 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edsko edsko

Labels
bug Something isn't working byron Required for a Byron mainnet: replace the old core nodes with cardano-node consensus issues related to ouroboros-consensus
Projects
None yet
Milestone
S6 2020-02-13
Development

No branches or pull requests
2 participants
@mrBliss @edsko