Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAD-3444 typed-protocols changes from p2p-master #3374

Merged
merged 5 commits into from
Oct 15, 2021

Conversation

coot
Copy link
Contributor

@coot coot commented Sep 20, 2021

  • typed-protocols: added TokPeerRole
  • typed-protocols: Codecs
  • typed-protocols-cborg: CBOR codecs for typed-protocols
  • typed-protocols-examples: added CBOR codecs
  • typed-protocols: udpated upstream dependencies

A singleton type for PeerRole; It is useful when writing application
code that can be shared between client and server.
Moved 'Network.TypedProtocol.Codec' module to typed-protocols package.
Include CBOR codecs & tests for:
* `PingPong` mini-protocol
* `ReqResp`  mini-protocol

This patch makes `typed-protocols-examples` contain all the
implementation details for `PingPong` and `ReqResp` protocols.
Copy link
Contributor

@dcoutts dcoutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@coot
Copy link
Contributor Author

coot commented Oct 15, 2021

bors merge

iohk-bors bot added a commit that referenced this pull request Oct 15, 2021
3374: CAD-3444 typed-protocols changes from p2p-master r=coot a=coot

- typed-protocols: added TokPeerRole
- typed-protocols: Codecs
- typed-protocols-cborg: CBOR codecs for typed-protocols
- typed-protocols-examples: added CBOR codecs
- typed-protocols: udpated upstream dependencies


Co-authored-by: Marcin Szamotulski <profunctor@pm.me>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Oct 15, 2021

Build failed:

Updated: `ouroboros-network-framework`, `ouroboros-network` and
`ouroboros-consensus` after restructuring `typed-protocols` packages.
@coot
Copy link
Contributor Author

coot commented Oct 15, 2021

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Oct 15, 2021

@iohk-bors iohk-bors bot merged commit e8875cf into master Oct 15, 2021
@iohk-bors iohk-bors bot deleted the coot/p2p-typed-protocols branch October 15, 2021 13:50
@coot coot added the peer2peer label Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typed-protocols Issues related to typed-protocols
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants