Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added central configuration module #4808

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Added central configuration module #4808

merged 1 commit into from
Mar 8, 2024
+125 −0

Conversation

crocodile-dentist
Copy link
Contributor

Description

resolves #4805

Checklist

  • Branch
    • Updated changelog files.
    • Commit sequence broadly makes sense
    • Commits have useful messages
    • The documentation has been properly updated
    • New tests are added if needed and existing tests are updated
    • If serialization changes, user-facing consequences (e.g. replay from genesis) are confirmed to be intentional.
  • Pull Request
    • Self-reviewed the diff
    • Useful pull request description at least containing the following information:
      • What does this PR change?
      • Why these changes were needed?
      • How does this affect downstream repositories and/or end-users?
      • Which ticket does this PR close (if any)? If it does, is it linked?
    • Reviewer requested

@crocodile-dentist crocodile-dentist added good first issue Good for newcomers diffusion Issues / PRs related to diffusion layer labels Feb 19, 2024
@coot coot marked this pull request as draft February 19, 2024 10:53
@coot coot changed the title DRAFT: Adds central configuration module Added central configuration module Feb 19, 2024
@crocodile-dentist crocodile-dentist self-assigned this Feb 19, 2024
@crocodile-dentist crocodile-dentist force-pushed the logistics/network-conf branch 2 times, most recently from 04de08d to 4ddf42b Compare February 21, 2024 18:08
@crocodile-dentist
Copy link
Contributor Author

Merge Armando's #4795 before this.

@crocodile-dentist crocodile-dentist force-pushed the logistics/network-conf branch 3 times, most recently from 159df5d to bb125ce Compare February 22, 2024 08:36
@coot
Copy link
Contributor

coot commented Feb 22, 2024

Once this is merged, we should integrate the changes to ouroboros-consensus and cardano-node. I'd prefer if we do that than leave it to the next release-engineer.

@coot coot marked this pull request as ready for review March 6, 2024 19:07
@coot coot requested a review from a team as a code owner March 6, 2024 19:07
@coot coot self-requested a review March 6, 2024 19:15
coot
coot approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@coot coot left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; #4795 was merged, once rebased & conflicts are resolved this can be merged.

@crocodile-dentist crocodile-dentist force-pushed the logistics/network-conf branch 2 times, most recently from 57d480f to 19b185f Compare March 7, 2024 09:36
@crocodile-dentist crocodile-dentist added this pull request to the merge queue Mar 8, 2024
Merged via the queue into master with commit cfb1c7e Mar 8, 2024
14 checks passed
@crocodile-dentist crocodile-dentist deleted the logistics/network-conf branch March 8, 2024 14:18
@coot coot mentioned this pull request Apr 13, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bolt12 bolt12 bolt12 left review comments

@coot coot coot approved these changes

Assignees

@crocodile-dentist crocodile-dentist

Labels
diffusion Issues / PRs related to diffusion layer good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pull configuration values to ouroboros-network
3 participants
@crocodile-dentist @coot @bolt12