Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IP-109] Added selection menus to allow the user to select the PDF template #614

Merged
merged 32 commits into from Jan 23, 2021

Conversation

749
Copy link

@749 749 commented Mar 16, 2018

Pull Request Checklist

  • My code follows the code formatting guidelines.
  • I have an issue ID for this pull request.
  • I selected the corresponding branch. (v1.6.0)
  • I have rebased my changes on top of the corresponding branch.

Issue Type (Please check one or more)

  • Bugfix
  • Improvement of an existing Feature
  • New Feature

This is likely not the full fix for the issue, but hopefully a step in the right direction.

This PR adds a dropdown-submenu to the "Download PDF" so the user can choose the PDF at invoice/quote creation. The current system-default is highlighted by a chevron.

See image below for an example of what it adds to the system

image

Kovah and others added 30 commits September 18, 2017 11:50
This fixes the 500 error on php5.6
Cuando se añade una cuenta de usuario de tipo invitado. Al añadir los clientes que puede ver, aparece una nueva opción que nos permite añadir todos los clientes automáticamente. También cuando se cree un nuevo cliente este se añadira a todos las cuentas de usuario que tengan esta opción habilitada. Muy útil para cuentas de usuario que usarán en contabilidad.

---

When a user type user account is added. When you add the clients you can see, a new option appears that allows us to add all clients automatically. Also when a new client is created this will be added to all user accounts that have this option enabled. Very useful for user accounts that will be used in accounting.
Corregida la frase de la variable user_all_clients_text

---

Corrected the phrase of the variable user_all_clients_text
The same custom fields will be available as what is available in a PDF
template.

Forum topic: https://community.invoiceplane.com/t/topic/4223/26
As $mdl_invoice_tax_rates is not available in the copy_invoice function we load the corresponding model first. Couldn't reproduce the error but this should work.
+ various smaller code corrections
# Conflicts:
#	application/modules/guest/controllers/Payment_handler.php
@Kovah Kovah added this to the 1.6.0 milestone Apr 9, 2018
@kintaro1981
Copy link

this is another PR related to #109 :
#334

@nielsdrost7
Copy link
Contributor

@foegra
Copy link

foegra commented Dec 18, 2020

Hello, what about this pull request?
This is something i miss a lot in the app.

@UnderDogg
Copy link
Contributor

Hey @foegra,
We can't automatically merge this PR, it's failing one of the checks.
We're working on a new version and maybe I can bring in this feature, but I need to make sure all the checks are passing.

Hope you understand and thanks for bringing it to our attention

@UnderDogg UnderDogg changed the base branch from v1.6.0 to release January 23, 2021 12:44
@UnderDogg UnderDogg merged commit 1bb7870 into InvoicePlane:release Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants