Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make product.* available in quotes #717

Merged
merged 1 commit into from
Jan 23, 2021

Conversation

ctsde-markus
Copy link
Contributor

Make $item->product values available in quotes (just as they are in invoices) as announced in the forum https://community.invoiceplane.com/t/topic/9188

Pull Request Checklist

  • My code follows the code formatting guidelines.
  • I have an issue ID for this pull request. (Issues are deactivated?)
  • I selected the corresponding branch.
  • I have rebased my changes on top of the corresponding branch.

Issue Type (Please check one or more)

  • Bugfix
  • Improvement of an existing Feature
  • New Feature

Make $item->product values available in quotes (just as they are in invoices)
@the-hotmann
Copy link
Member

Thanks for your contribution.

Here is your testfile. Please be aware that this is not tested and is an unofficial build just for you (your PR).

# Value
name MarkusTestv1.5.12-Preview.zip
md5 e23036f16099e3256a39c7640607c82d
sha256 4d3f0e7bc4922d7408995e2b83a1844bfc1edb8a3bdbbc856d6fa2503fac6f60
size 13.250 MiB

Downloadlink 1: LINK
Checksumlink 1: LINK

Downloadlink 2: LINK
Checksumlink 2: LINK

Please review your testbuild and test it. After this give feedback and tell us if everything was fine.

@UnderDogg UnderDogg changed the base branch from 1.5.12 to release January 23, 2021 11:32
@UnderDogg UnderDogg merged commit 588db9d into InvoicePlane:release Jan 23, 2021
@UnderDogg
Copy link
Contributor

UnderDogg commented Jan 23, 2021

Thank you for the pull-request. I've merged it into the release branch (a temporary branch). Eventually it will be merged into the 1.5.12 release.

@ctsde-markus
Copy link
Contributor Author

Sorry for the late reply (we had some private affairs here).

I now have a development VM to test such previews here. The MarkusTestv1.5.12-Preview.zip works for me as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants