PHP8.1 compatibility #831

vtq221 · 2022-07-25T02:52:12Z

PHP8.1 compatibility changes - see #798

https://php.watch/versions/8.1

Testing progress against PHP8.1

phpcompatibility/php-compatibility code scan for errors
Core functionality (login, session, view render, save form data, nav menu)
Modules: clients, quotes, invoices, payments products, tasks, reports
PDF creation
Email
System settings
Recurring invoices / cron
Create user
Custom fields

Pull Request Checklist

My code follows the code formatting guidelines.
I have an issue ID for this pull request.
I selected the corresponding branch.
I have rebased my changes on top of the corresponding branch.

Issue Type (Please check one or more)

Bugfix
Improvement of an existing Feature
New Feature
Compatibility with new software

…icePlane#831

…#798

…he pre PHP81 default to avoid unexpected behaviour. see https://php.watch/versions/8.1/html-entity-default-value-changes

…nt methods will no longer be supported if this change is merged InvoicePlane#798

…making successful API calls

onny · 2022-09-02T14:22:33Z

Is a new offical release with PHP8 support planned any time soon? Looking forward to it otherwise we'll have to drop Invoiceplane from NixOS :,(

clockwiseq · 2022-09-02T14:30:40Z

Is a new offical release with PHP8 support planned any time soon? Looking forward to it otherwise we'll have to drop Invoiceplane from NixOS :,(

Although we do not have a schedule or a date just yet, we are planning on releasing a new version that is compatible with PHP8 and we plan on staying compatible with the latest PHP releases going forward. I know that doesn't really answer your question, but at least letting you know that we do plan on releasing a new version, just not scheduled yet.

nielsdrost7 · 2022-09-02T15:48:49Z

@onny thank you for your question.

This PR is that PHP 8.1 compatible version.
We can release it any time, but we're waiting for a tactically right time.

WalleBE · 2022-09-26T20:12:25Z

Hi, is it safe to use this version? My provider is stopping php 7.4 support.
I'm happy to test.

vtq221 · 2022-09-27T07:26:12Z

Hi there,

Testing would be great if you can take a look. Based on my testing it's working well but it would be good to get some more testers - I should have time to fix any specific issues identified. I don't have time right now to do thorough testing myself.

The only exception is online payments - I haven't had time to implement online payments for PHP8. It could take some time.

I'll do my best to resolves issues identified by testers, but unfortunately I've been very busy lately so haven't been able to thoroughly test myself. I've been using this version myself with no issues for several months.

If anyone needs online payments, maybe post which provider you use. Without more help, I won't be able to implement all the current supported payment providers.

WalleBE · 2022-09-27T10:43:05Z

Hi, I'm not using payments functions, I'll test standard function as deep as possible :-)

nielsdrost7 · 2022-09-27T11:12:00Z

Thanks guys, really appreciate it!

onny · 2022-10-02T12:57:17Z

I don't use payments too and would be happy to use InvoicePlane with PHP8. I'm trying to package this pull request on NixOS for easier testing in maybe upgrading to this unstable release to avoid dropping it due to missing PHP8 support: NixOS/nixpkgs#194059

I build it from source with

composer install --ignore-platform-req=ext-bcmath --ignore-platform-req=ext-gd
yarn build
yarn install

When opening Invoiceplane in the browser I get

Fatal error: Uncaught TypeError: Dotenv\Dotenv::__construct(): Argument #1 ($store) must be of type Dotenv\Store\StoreInterface, string given, called in /nix/store/fvcmmirjs4434624jbr0rlmla266q22q-invoiceplane-localhost-unstable-2022-08-08/index.php on line 18 and defined in /nix/store/fvcmmirjs4434624jbr0rlmla266q22q-invoiceplane-localhost-unstable-2022-08-08/vendor/vlucas/phpdotenv/src/Dotenv.php:60 Stack trace: #0 /nix/store/fvcmmirjs4434624jbr0rlmla266q22q-invoiceplane-localhost-unstable-2022-08-08/index.php(18): Dotenv\Dotenv->__construct() #1 {main} thrown in /nix/store/fvcmmirjs4434624jbr0rlmla266q22q-invoiceplane-localhost-unstable-2022-08-08/vendor/vlucas/phpdotenv/src/Dotenv.php on line 60

nielsdrost7 · 2022-10-02T13:03:30Z

@onny did you make a copy of the ipconfig.php.example file to ipconfig.php?
It's thr first thing I'm thinking of when I see these types of errors

onny · 2022-10-02T13:14:48Z

Thank you for the fast feedback. Should be present. It is the kind of config I used in Invoiceplane 1.5.11. Not sure if something changed in the meantime

$ curl http://localhost/ipconfig.php
IP_URL=http://localhost
ENABLE_DEBUG=false
DISABLE_SETUP=false
REMOVE_INDEXPHP=false
DB_HOSTNAME=localhost
DB_USERNAME=invoiceplane
# NOTE: file_get_contents adds newline at the end of returned string
DB_PASSWORD=
DB_DATABASE=invoiceplane
DB_PORT=3306
SESS_EXPIRATION=864000
ENABLE_INVOICE_DELETION=false
DISABLE_READ_ONLY=false
ENCRYPTION_KEY=
ENCRYPTION_CIPHER=AES-256
SETUP_COMPLETED=false

nielsdrost7 · 2022-10-02T13:16:01Z

Config looks good.
It's something else and it needs some debugging.

phpdotenv has changed (quick Google search)

nielsdrost7 · 2022-10-02T13:23:50Z

@onny can you move phpdotenv back to an older version?

"vlucas/phpdotenv": "^3.4.0"

WalleBE · 2022-10-03T21:24:22Z

Hi, I cannot find the vendor-folder in the repository. Is it safe to use the folder from V 1.6.11?
If I do, I got this fault: Fatal error: Uncaught Error: Call to undefined method Dotenv\Dotenv::createImmutable() in /data/sites/web/www/ip_8/index.php:19 Stack trace: #0 {main} thrown in /data/sites/web/www/ip_8/index.php on line 19

nielsdrost7 · 2022-10-04T03:50:13Z

@WalleBE usually these types of questions go on the forums or in the slack channels, but I'll let it slide for this time. I've created a github issue #857 for you, so you can receive your answer.

Right now, here, we comment on the Pull-request, that gets us to PHP8 compatibility. Let's keep it that way

onny · 2022-10-04T12:08:47Z

@onny can you move phpdotenv back to an older version?

"vlucas/phpdotenv": "^3.4.0"

Oh sorry it seems it was my mistake. I patched index.php file in my NixOS module to override custom options/settings https://github.com/NixOS/nixpkgs/blob/fd54651f5ffb4a36e8463e0c327a78442b26cbe7/nixos/modules/services/web-apps/invoiceplane.nix#L42

There I used the dotenv function which doesn't seem to be compatible with the latest version of it. I need to fix this myself. On the other side Invoiceplane seems to work with PHP8.1 using this branch. Hope the development gets merged into master soon so we can start testing and fixing bugs :)

nielsdrost7 · 2022-10-04T13:14:04Z

Hope the development gets merged into master soon so we can start testing and fixing bugs :)

I'll merge into development soon.
I would love to keep the master version for when we make a release, which would also be very soon.

The plan is to put phpdotenv back to 3.4 and then merge this PHP 8.1 branch. Soon, soon.

I patched index.php file in my NixOS module to override custom options/settings
I'm interested in those customizations. Tell me on slack if you like

onny · 2022-10-04T13:23:38Z

For me it works with phpdotenv at the latest version. Version 3.4 won't probably work because it doesn't support PHP8

nielsdrost7 · 2022-10-07T11:36:36Z

@vtq221 @onny could you guys please contact me on our slack channels this weekend? I would love to go over some things with you
https://join.slack.com/t/invoiceplane/shared_invite/zt-sjirc9h2-952baR9rn4r8LyzRK9MveA

onny · 2022-10-16T10:00:46Z

Thank you for merging :) Is this already in master or develop branch?

nielsdrost7 · 2022-10-16T10:01:59Z

@onny it's in the branch https://github.com/InvoicePlane/InvoicePlane/tree/feature/issue-798 for now.
This branch will help us to add more things, to prepare for the new release (npm packages update, readme, you know, the works)

vtq221 added 3 commits July 25, 2022 12:34

PHPDotEnv updated and code compatibility

07145ae

Handling of null values for PHP8.1

6dba6a0

Quick fix for PHPDotEnv - it needs a comment before the PHP

d43de8e

nielsdrost7 approved these changes Jul 25, 2022

View reviewed changes

nielsdrost7 changed the title ~~Development~~ PHP8.1 compatibility Jul 25, 2022

vtq221 added 4 commits July 25, 2022 16:53

same treatment for quote model as invoice model for PHP8.1 issue Invo…

817a47a

…icePlane#831

Removed deprecated ini setting

c2fccec

More PHP8.1 fixes to MX loader InvoicePlane#798

d0ad8cc

Just in case change due to new handling of func_get_args InvoicePlane…

0c05f6a

…#798

nielsdrost7 mentioned this pull request Jul 31, 2022

Paypal API interaction with Client ID and Secret #757

Open

vtq221 marked this pull request as draft August 1, 2022 14:45

vtq221 added 3 commits August 2, 2022 23:39

Missing fix from last commit - PHPDotEnv InvoicePlane#798

821f872

More null handling for PHP8.1 InvoicePlane#798

10addbb

$798 - more null handling, and revert html entity function flags to t…

96ceca4

…he pre PHP81 default to avoid unexpected behaviour. see https://php.watch/versions/8.1/html-entity-default-value-changes

vtq221 force-pushed the development branch from e3c8adf to 96ceca4 Compare August 2, 2022 14:47

vtq221 and others added 3 commits August 3, 2022 01:54

Omnipay update to V3 for PHP81 compatibility - note many online payme…

e2424de

…nt methods will no longer be supported if this change is merged InvoicePlane#798

Formatting fix Modules.php

4943771

stripe.js forbidden - quick fix. stripe still not working, though is …

7402b37

…making successful API calls

nielsdrost7 mentioned this pull request Aug 12, 2022

[1.6] Update Readme #782

Closed

naui95 pushed a commit that referenced this pull request Oct 1, 2022

same treatment for quote model as invoice model for PHP8.1 issue #831

451a4f3

naui95 mentioned this pull request Oct 8, 2022

PHP8 compatibility branch: phpdotenv is too new #855

Closed

naui95 linked an issue Oct 15, 2022 that may be closed by this pull request

php 7.4 EoL in 9 months. php 8.1 required #798

Closed

naui95 changed the base branch from development to feature/issue-798 October 15, 2022 11:33

reverted change to .example file

68ba3ee

naui95 mentioned this pull request Oct 16, 2022

Fix the php8.1 migration #858

Merged

7 tasks

nielsdrost7 merged commit 68ba3ee into InvoicePlane:feature/issue-798 Oct 16, 2022

nielsdrost7 pushed a commit that referenced this pull request Oct 16, 2022

same treatment for quote model as invoice model for PHP8.1 issue #831

b6a70de

aksysict mentioned this pull request Nov 13, 2022

php 7.4 EoL in 9 months. php 8.1 required #798

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PHP8.1 compatibility #831

PHP8.1 compatibility #831

vtq221 commented Jul 25, 2022 •

edited by nielsdrost7

Loading

onny commented Sep 2, 2022

clockwiseq commented Sep 2, 2022

nielsdrost7 commented Sep 2, 2022

WalleBE commented Sep 26, 2022

vtq221 commented Sep 27, 2022

WalleBE commented Sep 27, 2022

nielsdrost7 commented Sep 27, 2022

onny commented Oct 2, 2022 •

edited

Loading

nielsdrost7 commented Oct 2, 2022 •

edited

Loading

onny commented Oct 2, 2022

nielsdrost7 commented Oct 2, 2022 •

edited

Loading

nielsdrost7 commented Oct 2, 2022

WalleBE commented Oct 3, 2022

nielsdrost7 commented Oct 4, 2022 •

edited

Loading

onny commented Oct 4, 2022

nielsdrost7 commented Oct 4, 2022

onny commented Oct 4, 2022

nielsdrost7 commented Oct 7, 2022

onny commented Oct 16, 2022

nielsdrost7 commented Oct 16, 2022 •

edited

Loading

PHP8.1 compatibility #831

PHP8.1 compatibility #831

Conversation

vtq221 commented Jul 25, 2022 • edited by nielsdrost7 Loading

onny commented Sep 2, 2022

clockwiseq commented Sep 2, 2022

nielsdrost7 commented Sep 2, 2022

WalleBE commented Sep 26, 2022

vtq221 commented Sep 27, 2022

WalleBE commented Sep 27, 2022

nielsdrost7 commented Sep 27, 2022

onny commented Oct 2, 2022 • edited Loading

nielsdrost7 commented Oct 2, 2022 • edited Loading

onny commented Oct 2, 2022

nielsdrost7 commented Oct 2, 2022 • edited Loading

nielsdrost7 commented Oct 2, 2022

WalleBE commented Oct 3, 2022

nielsdrost7 commented Oct 4, 2022 • edited Loading

onny commented Oct 4, 2022

nielsdrost7 commented Oct 4, 2022

onny commented Oct 4, 2022

nielsdrost7 commented Oct 7, 2022

onny commented Oct 16, 2022

nielsdrost7 commented Oct 16, 2022 • edited Loading

vtq221 commented Jul 25, 2022 •

edited by nielsdrost7

Loading

onny commented Oct 2, 2022 •

edited

Loading

nielsdrost7 commented Oct 2, 2022 •

edited

Loading

nielsdrost7 commented Oct 2, 2022 •

edited

Loading

nielsdrost7 commented Oct 4, 2022 •

edited

Loading

nielsdrost7 commented Oct 16, 2022 •

edited

Loading