Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the php8.1 migration #858

Conversation

ThierryHFR
Copy link

@ThierryHFR ThierryHFR commented Oct 15, 2022

Pull Request Checklist

  • My code follows the code formatting guidelines.
  • I have an issue ID for this pull request.
  • I selected the corresponding branch.
  • I have rebased my changes on top of the corresponding branch.

Issue Type (Please check one or more)

  • Bugfix
  • Improvement of an existing Feature
  • New Feature

@naui95 naui95 linked an issue Oct 15, 2022 that may be closed by this pull request
@naui95 naui95 changed the base branch from development to feature/issue-798 October 15, 2022 11:32
@naui95 naui95 self-requested a review October 15, 2022 11:32
@ThierryHFR
Copy link
Author

Hi @naui95 and @vtq221,
I created this morning a pull-request on the wrong repository.
This pull-request fix the php8.1 migration.
I based my work on vtq221:development
I just pushed my changes here vtq221#1

@naui95
Copy link
Contributor

naui95 commented Oct 16, 2022

Hi @Ordissimo, thank you 👍. We noticed your changes were made against PR #831 and therefore the plan is to merge them after the aforementioned PR in branch feature/issue-798 and from there bring all the awesome PHP8 compatibility code into the development branch which will bring to a new release.

@nielsdrost7 nielsdrost7 changed the base branch from feature/issue-798 to feature/798-php-8-compatibility October 16, 2022 10:17
@nielsdrost7 nielsdrost7 merged commit 5c836aa into InvoicePlane:feature/798-php-8-compatibility Oct 16, 2022
@ThierryHFR ThierryHFR deleted the development branch October 16, 2022 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants