Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing default language does not work #43

Closed
Hoschi1982 opened this issue Mar 1, 2024 · 4 comments
Closed

Changing default language does not work #43

Hoschi1982 opened this issue Mar 1, 2024 · 4 comments
Labels
bug Something isn't working needs investigation investigation is needed
Milestone

Comments

@Hoschi1982
Copy link

Describe the bug
When I change the default language in the preference View nothing happens.
The language is always english

Expected behavior
Language should change

Screenshots
If applicable, add screenshots to help explain your problem.

Please complete the following information:

  • InvoiceShelf version: 1.1.0

Optional info

  • OS: docker
@gdarko gdarko added bug Something isn't working needs investigation investigation is needed labels Mar 3, 2024
@digipifini
Copy link

Noticed this myself, but I there seems to still be some work to do adding additional languages. If you look under /resources/lang/ the only available option is the EN (english) folder. This will require multiple people working to complete full translations, perhaps a POT module developed using CrowdIn or any other crowdsourced translation tool.

@Hoschi1982
Copy link
Author

Hy,
Thanks for your fast reply.

Crater has several translations. Privately I use a self-hosted weblate instance for translation. Automatic translations can also be carried out here in conjunction with a self-hosted libreTranslate instance. Idea: The languages ​​should be checked in in Crater... if not, maybe you try selecting different languages ​​in Crater and downloading the corresponding json file for each language? Then everything doesn't have to be translated again. There's no rush. I might as well try it.

@spoutnikfr
Copy link

Localisation exist there :

resources/scripts/locales/en.json
I think the upgrade to Laravel 10 + VueJS 3.4 broke the i18n function and need to be carefully patched.

mchev added a commit to mchev/InvoiceShelf that referenced this issue Mar 16, 2024
@gdarko gdarko added this to the 1.2.0 milestone Mar 22, 2024
gdarko pushed a commit that referenced this issue Mar 27, 2024
* Fix locales issue #43

* Adding open-direction bottom to the language multiselect
@gdarko
Copy link

gdarko commented Mar 27, 2024

This is fixed with #46 - Awaiting 1.2.0 release.

@gdarko gdarko closed this as completed Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs investigation investigation is needed
Projects
None yet
Development

No branches or pull requests

4 participants