Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix locales issue #43 #46

Merged
merged 4 commits into from
Mar 27, 2024
Merged

Fix locales issue #43 #46

merged 4 commits into from
Mar 27, 2024

Conversation

mchev
Copy link

@mchev mchev commented Mar 16, 2024

Related to #43

  • Updated global.locale to global.locale.value in /resources/scripts/admin/stores/global.js to ensure compatibility with Vue 3 reactivity system.
  • Relocated translation files to adhere to Laravel's folder convention for enhanced organization and streamlined translation contributions.

To be checked with modules.

Also it seems that the open-direction="top" on BaseSelect component is broken.

@gdarko
Copy link

gdarko commented Mar 26, 2024

Hey @mchev - I̶ t̶e̶s̶t̶e̶d̶ y̶o̶u̶r̶ p̶u̶l̶l̶ b̶u̶t̶ i̶t̶ l̶o̶o̶k̶s̶ l̶i̶k̶e̶ t̶h̶e̶ l̶a̶n̶g̶u̶a̶g̶e̶ s̶t̶i̶l̶l̶ d̶o̶e̶s̶n̶'t̶ c̶h̶a̶n̶g̶e̶. L̶e̶t̶ m̶e̶ d̶i̶g̶ i̶n̶t̶o̶ t̶h̶i̶s̶ m̶o̶r̶e̶ i̶n̶ d̶e̶t̶a̶i̶l̶s̶.

Sorry - my bad, i pulled the wrong branch :-). I can see it works now.

@mchev - one more change, can we please have open-direction="bottom" besides searchable to keep it consistent with the other areas.

Looks like the open-direction=top is not implemented yet so everywhere where the app uses top as a value is simply problematic currently - i think i will just address this in separate PR.

@gdarko gdarko self-requested a review March 26, 2024 22:21
Copy link

@gdarko gdarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks.

@gdarko gdarko merged commit 223678e into InvoiceShelf:master Mar 27, 2024
5 checks passed
@mchev mchev deleted the locales branch June 22, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants