Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M-07, M-13, M-15, L-02, CR-01 (OZ Audit) #27

Merged
merged 7 commits into from Jan 18, 2024
Merged

M-07, M-13, M-15, L-02, CR-01 (OZ Audit) #27

merged 7 commits into from Jan 18, 2024

Conversation

HrikB
Copy link
Collaborator

@HrikB HrikB commented Jan 4, 2024

  • Pausing safe actions did not pause interest accrual as intended which it does now.
  • Accruing interest for one ilk is also not actually possible since the interest rate is a function of the totalSupply and when one ilk is accrued, that changes the interest rate for all other collaterals. So individual accruals have been completely removed and appropriate view functions have been added/removed with this change.
  • Protocol liqudations have been made pausable as well (unsafe pause).
  • Finally, due to tiny edge case, interest also needs to be accrued on withdrawals and deposits of collateral. Consider the case where a user tried to withdraw an amount that would not violate LTV, but would violate LTV after accrual.

Issue CR-01
This issue no longer needs to be resolved since accrueInterestForIlkIndex has been removed.

…which it does now. Accruing interest for one ilk is also not actually possible. So individual accruals have been completely removed and appropriate view functions have been added/removed with this change. Protocol liqudations have been made pausable as well (unsafe). Finally, due to tiny edge case, interest also needs to be accrued on withdrawals and deposits of collateral.
@HrikB HrikB changed the title M-07, M-13, M-15, L-02 (OZ Audit) M-07, M-13, M-15, L-02, CR-01 (OZ Audit) Jan 4, 2024
…ued values (like balanceOf()). Also have non-accrued versions where necessary (like totalSupplyUnaccrued())
@HrikB HrikB mentioned this pull request Jan 5, 2024
@HrikB HrikB requested a review from junkim012 January 18, 2024 05:34
@HrikB HrikB added bug Something isn't working and removed bug Something isn't working labels Jan 18, 2024
@HrikB HrikB merged commit deb68bb into master Jan 18, 2024
@HrikB HrikB deleted the hrikb/M-07 branch January 18, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants