Skip to content

Commit

Permalink
Removed forced garbage collection as it led to crashes on Linux (pkul…
Browse files Browse the repository at this point in the history
…chenko#425, closes pkulchenko#464).

The forced collection didn't have the expected effect and also caused
sporadic crashes on some Linux versions.
  • Loading branch information
pkulchenko authored and IonoclastBrigham committed May 28, 2015
1 parent 41bc20a commit 5cc2e53
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions src/editor/commands.lua
Original file line number Diff line number Diff line change
Expand Up @@ -970,12 +970,6 @@ ide.editorApp:Connect(wx.wxEVT_ACTIVATE_APP,
local active = event:GetActive()
-- save auto-recovery record when making the app inactive
if not active then saveAutoRecovery(true) end
-- also collect all the garbage on switching *from* the app,
-- but on Linux, do it on switching *to* the app, as this event is
-- called in too many places and collectgarbage call leads to a crash
-- on mouse right click in edited element in the file tree.
local linux = ide.osname == 'Unix'
if (linux and active) or (not linux and not active) then collectgarbage() end

-- disable UI refresh when app is inactive, but only when not running
wx.wxUpdateUIEvent.SetUpdateInterval(
Expand Down

0 comments on commit 5cc2e53

Please sign in to comment.