Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds in toggleable crosshairs #6

Merged
merged 4 commits into from
Oct 9, 2018
Merged

Adds in toggleable crosshairs #6

merged 4 commits into from
Oct 9, 2018

Conversation

elistone
Copy link
Contributor

@elistone elistone commented Oct 8, 2018

Solves issue #5.
I did run into some issues with running the project which need up needing an extra module "babel-polyfill" because of ReferenceError: regeneratorRuntime is not defined babel/babel#5085

Though I saw you had "babel-plugin-transform-runtime" it still did not work for me.

Eli Stone and others added 4 commits October 8, 2018 16:34
@Irev-Dev
Copy link
Owner

Irev-Dev commented Oct 9, 2018

Awesome, really happy with your work. I'm seeing a lot of white space changes which is my bad, I really should have set up a linter by this point.
I'm really happy that you have the crosshairs update as soon as the check boxes changes and not wait for another change on the canvases themselves for it to apply.
The polyfill issue is a little weird after I installed it and added the .babelrc file it started working without importing it into the project so 🤷‍♀️ It's probably best to have it explicitly imported as you've done.

I've got a commit that I'll push soon (on my phone can push now) where I've just added the cross hair colors and the transparent color into variables.

I'll merge this soon, but I'll likely put another issue up later to get the cross hairs to display on page load. Thanks for your help.

Copy link
Owner

@Irev-Dev Irev-Dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@Irev-Dev Irev-Dev merged commit 4783cd0 into Irev-Dev:master Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants