Single Person model and more #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
migration from zero (old app will not migrate) type and subtype added additional search additions, __str__ tweaks, column tweaks
|
Opening PR for posterity but not expecting any actual review before deploying and demoing with the team. |
stenington
added a commit
that referenced
this pull request
Mar 2, 2015
Single Person model and more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR substantially changes the organization of the app from ParentGuardian & Student models to a single Person model with Type and Subtypes. It seemed like bringing this closer to keytag's data model might make life easier for the time being, so types and subtypes come straight from there and are configurable in the DB.
This PR also tries to improve the columns on each model's listing screen, and adds more info to various
__str__methods like adding ids and keytags toPerson.__str__which hopefully helps in selecting attendees in Sessions. I'm worried it decreases overall readability, but maybe it's fine or we can do some fancier text formatting or something.